Re: [PATCH v2] media: platform: fix a kernel warning on clk control

2019-04-12 Thread Jae Hyun Yoo
On 4/12/2019 7:33 AM, Eddie James wrote: On 4/12/19 7:17 AM, Herrenschmidt, Benjamin wrote: On Fri, 2019-04-12 at 13:00 +0200, Hans Verkuil wrote: Eddie, can you review this? Yes, this looks good. Thanks, Reviewed-by: Eddie James Thanks Eddie! I'll submit a new patch on top of your up

Re: [PATCH v2] media: platform: fix a kernel warning on clk control

2019-04-12 Thread Jae Hyun Yoo
On 4/12/2019 5:17 AM, Herrenschmidt, Benjamin wrote: On Fri, 2019-04-12 at 13:00 +0200, Hans Verkuil wrote: Eddie, can you review this? Jae Hyun Yoo, for future reference: please add the driver name in the subject. I.e. something like this: [PATCH v2] media: aspeed: fix a kernel warning on clk

Re: [PATCH v2] media: platform: fix a kernel warning on clk control

2019-04-12 Thread Jae Hyun Yoo
On 4/12/2019 4:00 AM, Hans Verkuil wrote: Eddie, can you review this? Jae Hyun Yoo, for future reference: please add the driver name in the subject. I.e. something like this: [PATCH v2] media: aspeed: fix a kernel warning on clk control That helps maintainers figuring out who should look at wh

Re: [PATCH v2] media: platform: fix a kernel warning on clk control

2019-04-12 Thread Eddie James
On 4/12/19 7:17 AM, Herrenschmidt, Benjamin wrote: On Fri, 2019-04-12 at 13:00 +0200, Hans Verkuil wrote: Eddie, can you review this? Yes, this looks good. Thanks, Reviewed-by: Eddie James Jae Hyun Yoo, for future reference: please add the driver name in the subject. I.e. something l

Re: [PATCH v2] media: platform: fix a kernel warning on clk control

2019-04-12 Thread Herrenschmidt, Benjamin
On Fri, 2019-04-12 at 13:00 +0200, Hans Verkuil wrote: > Eddie, can you review this? > > Jae Hyun Yoo, for future reference: please add the driver name in the > subject. > I.e. something like this: [PATCH v2] media: aspeed: fix a kernel > warning on clk control > > That helps maintainers figuring

Re: [PATCH v2] media: platform: fix a kernel warning on clk control

2019-04-12 Thread Hans Verkuil
Eddie, can you review this? Jae Hyun Yoo, for future reference: please add the driver name in the subject. I.e. something like this: [PATCH v2] media: aspeed: fix a kernel warning on clk control That helps maintainers figuring out who should look at which patch. Regards, Hans On 3/29/

[PATCH v2] media: platform: fix a kernel warning on clk control

2019-03-29 Thread Jae Hyun Yoo
video_on and video_off functions in the Aspeed video engine driver are being called from multiple contexts without any protection so video clocks can be disabled twice and eventually it causes a kernel warning with stack dump printing out like below: [ 120.034729] WARNING: CPU: 0 PID: 1334 at dri