Re: [PATCH v2] media: i2c: ADV7604: Migrate to regmap

2015-06-19 Thread Hans Verkuil
On 06/16/2015 10:38 AM, Pablo Anton wrote: > This is a preliminary patch in order to add support for ALSA. > It replaces all current i2c access with regmap. > > Signed-off-by: Pablo Anton > Signed-off-by: Jean-Michel Hautbois After fixing the missing return value check that Lars-Peter found you

Re: [PATCH v2] media: i2c: ADV7604: Migrate to regmap

2015-06-19 Thread Lars-Peter Clausen
On 06/16/2015 10:38 AM, Pablo Anton wrote: This is a preliminary patch in order to add support for ALSA. It replaces all current i2c access with regmap. Looks pretty good. #define ADV76XX_REG(page, offset) (((page) << 8) | (offset)) @@ -633,13 +618,15 @@ static int adv76xx_read_reg(stru

[PATCH v2] media: i2c: ADV7604: Migrate to regmap

2015-06-16 Thread Pablo Anton
This is a preliminary patch in order to add support for ALSA. It replaces all current i2c access with regmap. Signed-off-by: Pablo Anton Signed-off-by: Jean-Michel Hautbois --- v2: Rebase after renaming drivers/media/i2c/adv7604.c | 337 1 file chan