Re: [PATCH v2] media: V4L2: add temporary clock helpers

2012-11-27 Thread Laurent Pinchart
Hello, On Sunday 25 November 2012 13:04:09 Sakari Ailus wrote: > Sylwester Nawrocki wrote: > > On 11/14/2012 02:06 PM, Laurent Pinchart wrote: > > ... > > > + > +static DEFINE_MUTEX(clk_lock); > +static LIST_HEAD(v4l2_clk); > >>> > >>> As Sylwester mentioned, w

Re: [PATCH v2] media: V4L2: add temporary clock helpers

2012-11-25 Thread Sakari Ailus
Hi Sylwester, Sylwester Nawrocki wrote: > Hi All, > > On 11/14/2012 02:06 PM, Laurent Pinchart wrote: > ... + +static DEFINE_MUTEX(clk_lock); +static LIST_HEAD(v4l2_clk); >>> >>> As Sylwester mentioned, what about s/v4l2_clk/v4l2_clks/ ? >> >> Don't you

Re: [PATCH v2] media: V4L2: add temporary clock helpers

2012-11-22 Thread Sylwester Nawrocki
Hi All, On 11/14/2012 02:06 PM, Laurent Pinchart wrote: ... + +static DEFINE_MUTEX(clk_lock); +static LIST_HEAD(v4l2_clk); As Sylwester mentioned, what about s/v4l2_clk/v4l2_clks/ ? Don't you think naming of a static variable isn't important enough? ;-) I think code authors should have enoug

Re: [PATCH v2] media: V4L2: add temporary clock helpers

2012-11-14 Thread Laurent Pinchart
Hi Sakari, On Tuesday 13 November 2012 01:37:51 Sakari Ailus wrote: > On Mon, Nov 12, 2012 at 12:06:50PM +0100, Laurent Pinchart wrote: > > On Monday 12 November 2012 00:33:17 Sakari Ailus wrote: > > > On Wed, Oct 31, 2012 at 02:02:54PM +0100, Guennadi Liakhovetski wrote: > > > > On Wed, 31 Oct 20

Re: [PATCH v2] media: V4L2: add temporary clock helpers

2012-11-12 Thread Sakari Ailus
Hi Laurent, On Mon, Nov 12, 2012 at 12:06:50PM +0100, Laurent Pinchart wrote: > On Monday 12 November 2012 00:33:17 Sakari Ailus wrote: > > On Wed, Oct 31, 2012 at 02:02:54PM +0100, Guennadi Liakhovetski wrote: > > > On Wed, 31 Oct 2012, Laurent Pinchart wrote: > > ... > > > > > > > +#include >

Re: [PATCH v2] media: V4L2: add temporary clock helpers

2012-11-12 Thread Laurent Pinchart
Hi Sakari, On Monday 12 November 2012 00:33:17 Sakari Ailus wrote: > On Wed, Oct 31, 2012 at 02:02:54PM +0100, Guennadi Liakhovetski wrote: > > On Wed, 31 Oct 2012, Laurent Pinchart wrote: > ... > > > > > +#include > > > > +#include > > > > +#include > > > > +#include > > > > +#include > > >

Re: [PATCH v2] media: V4L2: add temporary clock helpers

2012-11-12 Thread Laurent Pinchart
Hi Guennadi, On Wednesday 31 October 2012 14:02:54 Guennadi Liakhovetski wrote: > On Wed, 31 Oct 2012, Laurent Pinchart wrote: > > On Tuesday 30 October 2012 15:18:38 Guennadi Liakhovetski wrote: > > > Typical video devices like camera sensors require an external clock > > > source. Many such devi

Re: [PATCH v2] media: V4L2: add temporary clock helpers

2012-11-11 Thread Sakari Ailus
Hi Guennadi, Thanks for the patch! On Wed, Oct 31, 2012 at 02:02:54PM +0100, Guennadi Liakhovetski wrote: > On Wed, 31 Oct 2012, Laurent Pinchart wrote: ... > > > +#include > > > +#include > > > +#include > > > +#include > > > +#include > > > +#include > > > + > > > +#include > > > +#inclu

Re: [PATCH v2] media: V4L2: add temporary clock helpers

2012-10-31 Thread Guennadi Liakhovetski
Hi Laurent Thanks for the review On Wed, 31 Oct 2012, Laurent Pinchart wrote: > Hi Guennadi, > > Thanks for the patch. > > On Tuesday 30 October 2012 15:18:38 Guennadi Liakhovetski wrote: > > Typical video devices like camera sensors require an external clock source. > > Many such devices cann

Re: [PATCH v2] media: V4L2: add temporary clock helpers

2012-10-31 Thread Laurent Pinchart
Hi Guennadi, Thanks for the patch. On Tuesday 30 October 2012 15:18:38 Guennadi Liakhovetski wrote: > Typical video devices like camera sensors require an external clock source. > Many such devices cannot even access their hardware registers without a > running clock. These clock sources should b

[PATCH v2] media: V4L2: add temporary clock helpers

2012-10-30 Thread Guennadi Liakhovetski
Typical video devices like camera sensors require an external clock source. Many such devices cannot even access their hardware registers without a running clock. These clock sources should be controlled by their consumers. This should be performed, using the generic clock framework. Unfortunately