Re: [PATCH v2] V4L: add media bus configuration subdev operations

2011-07-01 Thread Guennadi Liakhovetski
On Thu, 30 Jun 2011, Sakari Ailus wrote: > On Wed, Jun 29, 2011 at 09:28:06PM +0200, Guennadi Liakhovetski wrote: > > On Wed, 29 Jun 2011, Sakari Ailus wrote: > > > > > Guennadi Liakhovetski wrote: > > > > On Mon, 27 Jun 2011, Guennadi Liakhovetski wrote: > > > > > > > > [snip] > > > > > > > >>

Re: [PATCH v2] V4L: add media bus configuration subdev operations

2011-06-30 Thread Sakari Ailus
On Wed, Jun 29, 2011 at 09:28:06PM +0200, Guennadi Liakhovetski wrote: > On Wed, 29 Jun 2011, Sakari Ailus wrote: > > > Guennadi Liakhovetski wrote: > > > On Mon, 27 Jun 2011, Guennadi Liakhovetski wrote: > > > > > > [snip] > > > > > >>> If the structures are expected to be generic I somehow fee

Re: [PATCH v2] V4L: add media bus configuration subdev operations

2011-06-29 Thread Guennadi Liakhovetski
On Wed, 29 Jun 2011, Sakari Ailus wrote: > Guennadi Liakhovetski wrote: > > On Mon, 27 Jun 2011, Guennadi Liakhovetski wrote: > > > > [snip] > > > >>> If the structures are expected to be generic I somehow feel that a field > >>> of > >>> flags isn't the best way to describe the configuration o

Re: [PATCH v2] V4L: add media bus configuration subdev operations

2011-06-29 Thread Sakari Ailus
Guennadi Liakhovetski wrote: > On Mon, 27 Jun 2011, Guennadi Liakhovetski wrote: > > [snip] > >>> If the structures are expected to be generic I somehow feel that a field of >>> flags isn't the best way to describe the configuration of CSI-2 or other >>> busses. Why not to just use a structure wi

Re: [PATCH v2] V4L: add media bus configuration subdev operations

2011-06-29 Thread Guennadi Liakhovetski
On Mon, 27 Jun 2011, Guennadi Liakhovetski wrote: [snip] > > If the structures are expected to be generic I somehow feel that a field of > > flags isn't the best way to describe the configuration of CSI-2 or other > > busses. Why not to just use a structure with bus type and an union for > > bus-

Re: [PATCH v2] V4L: add media bus configuration subdev operations

2011-06-27 Thread Guennadi Liakhovetski
On Mon, 27 Jun 2011, Sakari Ailus wrote: > Hi Guennadi, > > On Mon, Jun 27, 2011 at 10:54:11AM +0200, Guennadi Liakhovetski wrote: > > Hi Sakari > > > > On Mon, 27 Jun 2011, Sakari Ailus wrote: > > > > > On Fri, Jun 24, 2011 at 12:35:03AM +0200, Guennadi Liakhovetski wrote: > > > > Hi Sakari >

Re: [PATCH v2] V4L: add media bus configuration subdev operations

2011-06-27 Thread Sakari Ailus
Hi Guennadi, On Mon, Jun 27, 2011 at 10:54:11AM +0200, Guennadi Liakhovetski wrote: > Hi Sakari > > On Mon, 27 Jun 2011, Sakari Ailus wrote: > > > On Fri, Jun 24, 2011 at 12:35:03AM +0200, Guennadi Liakhovetski wrote: > > > Hi Sakari > > > > Hi Guennadi, > > > > > On Fri, 24 Jun 2011, Sakari A

Re: [PATCH v2] V4L: add media bus configuration subdev operations

2011-06-27 Thread Guennadi Liakhovetski
Hi Sakari On Mon, 27 Jun 2011, Sakari Ailus wrote: > On Fri, Jun 24, 2011 at 12:35:03AM +0200, Guennadi Liakhovetski wrote: > > Hi Sakari > > Hi Guennadi, > > > On Fri, 24 Jun 2011, Sakari Ailus wrote: > > > > > Hi Guennadi, > > > > > > Thanks for the patch. I have a few comments below. > > >

Re: [PATCH v2] V4L: add media bus configuration subdev operations

2011-06-27 Thread Sakari Ailus
On Fri, Jun 24, 2011 at 12:35:03AM +0200, Guennadi Liakhovetski wrote: > Hi Sakari Hi Guennadi, > On Fri, 24 Jun 2011, Sakari Ailus wrote: > > > Hi Guennadi, > > > > Thanks for the patch. I have a few comments below. > > > > On Wed, Jun 22, 2011 at 11:26:29PM +0200, Guennadi Liakhovetski wrote

Re: [PATCH v2] V4L: add media bus configuration subdev operations

2011-06-23 Thread Guennadi Liakhovetski
Hi Sakari On Fri, 24 Jun 2011, Sakari Ailus wrote: > Hi Guennadi, > > Thanks for the patch. I have a few comments below. > > On Wed, Jun 22, 2011 at 11:26:29PM +0200, Guennadi Liakhovetski wrote: > > Add media bus configuration types and two subdev operations to get > > supported mediabus confi

Re: [PATCH v2] V4L: add media bus configuration subdev operations

2011-06-23 Thread Sakari Ailus
Hi Guennadi, Thanks for the patch. I have a few comments below. On Wed, Jun 22, 2011 at 11:26:29PM +0200, Guennadi Liakhovetski wrote: > Add media bus configuration types and two subdev operations to get > supported mediabus configurations and to set a specific configuration. > Subdevs can suppor

Re: [PATCH v2] V4L: add media bus configuration subdev operations

2011-06-22 Thread Guennadi Liakhovetski
Hi Hans Thanks for the review, agree to all, except one: On Wed, 22 Jun 2011, Hans Verkuil wrote: > On Wednesday, June 22, 2011 23:26:29 Guennadi Liakhovetski wrote: [snip] > > +static inline unsigned long v4l2_mbus_config_compatible(struct > > v4l2_mbus_config *cfg, > > +

Re: [PATCH v2] V4L: add media bus configuration subdev operations

2011-06-22 Thread Hans Verkuil
On Wednesday, June 22, 2011 23:26:29 Guennadi Liakhovetski wrote: > Add media bus configuration types and two subdev operations to get > supported mediabus configurations and to set a specific configuration. > Subdevs can support several configurations, e.g., they can send video data > on 1 or seve

[PATCH v2] V4L: add media bus configuration subdev operations

2011-06-22 Thread Guennadi Liakhovetski
Add media bus configuration types and two subdev operations to get supported mediabus configurations and to set a specific configuration. Subdevs can support several configurations, e.g., they can send video data on 1 or several lanes, can be configured to use a specific CSI-2 channel, in such case