RE: [PATCH v2] [media] at91: add Atmel Image Sensor Interface (ISI) support

2011-06-03 Thread Wu, Josh
Hi, Arnd On Friday, May 27, 2011 9:50 PM, Arnd Bergmann wrote >On Friday 27 May 2011, Josh Wu wrote: >> This patch is to enable Atmel Image Sensor Interface (ISI) driver support. >> - Using soc-camera framework with videobuf2 dma-contig allocator >> - Supporting video streaming of YUV packed form

RE: [PATCH v2] [media] at91: add Atmel Image Sensor Interface (ISI) support

2011-06-03 Thread Wu, Josh
Hi, Jean-Christophe Thank you for the review. Jean-Christophe PLAGNIOL-VILLARD wrote on Friday, May 27, 2011 8:06 PM: >> +/* ISI interrupt service routine */ >> +static irqreturn_t isi_interrupt(int irq, void *dev_id) { >> +struct atmel_isi *isi = dev_id; >> +u32 status, mask, pending; >

RE: [PATCH v2] [media] at91: add Atmel Image Sensor Interface (ISI) support

2011-06-03 Thread Wu, Josh
Hi, Guennadi Guennadi Liakhovetski wrote on May 29, 2011 4:25 AM > Hi Josh > Thanks for the update. A general note: I much prefer the new IO accessors and > > register names and values - thanks for changing that! Thank you for the reviewing. I also think this version is clearer. :) Base on the

Re: [PATCH v2] [media] at91: add Atmel Image Sensor Interface (ISI) support

2011-05-28 Thread Guennadi Liakhovetski
Hi Josh Thanks for the update. A general note: I much prefer the new IO accessors and register names and values - thanks for changing that! On Fri, 27 May 2011, Josh Wu wrote: > This patch is to enable Atmel Image Sensor Interface (ISI) driver support. > - Using soc-camera framework with videob

Re: [PATCH v2] [media] at91: add Atmel Image Sensor Interface (ISI) support

2011-05-27 Thread Arnd Bergmann
On Friday 27 May 2011, Josh Wu wrote: > This patch is to enable Atmel Image Sensor Interface (ISI) driver support. > - Using soc-camera framework with videobuf2 dma-contig allocator > - Supporting video streaming of YUV packed format > - Tested on AT91SAM9M10G45-EK with OV2640 > > Signed-off-by: J

Re: [PATCH v2] [media] at91: add Atmel Image Sensor Interface (ISI) support

2011-05-27 Thread Jean-Christophe PLAGNIOL-VILLARD
> +/* ISI interrupt service routine */ > +static irqreturn_t isi_interrupt(int irq, void *dev_id) > +{ > + struct atmel_isi *isi = dev_id; > + u32 status, mask, pending; > + irqreturn_t ret = IRQ_NONE; > + > + spin_lock(&isi->lock); > + > + status = isi_readl(isi, ISI_STATUS); >

[PATCH v2] [media] at91: add Atmel Image Sensor Interface (ISI) support

2011-05-27 Thread Josh Wu
This patch is to enable Atmel Image Sensor Interface (ISI) driver support. - Using soc-camera framework with videobuf2 dma-contig allocator - Supporting video streaming of YUV packed format - Tested on AT91SAM9M10G45-EK with OV2640 Signed-off-by: Josh Wu --- Modified in V2 patch: move isi head fi