Re: [PATCH v1] ov5675: Add support for OV5675 sensor

2019-08-07 Thread Sakari Ailus
Hi Shawn, Thanks for the patch. A few comments below. On Wed, Jul 31, 2019 at 06:53:36PM +0800, Shawnx Tu wrote: ... > +static int ov5675_check_hwcfg(struct device *dev) > +{ > + struct fwnode_handle *ep; > + struct fwnode_handle *fwnode = dev_fwnode(dev); > + struct v4l2_fwnode_end

[PATCH v1] ov5675: Add support for OV5675 sensor

2019-07-31 Thread Shawnx Tu
From: Shawn Tu Add a V4L2 sub-device driver for Omnivision ov5675 image sensor. This is a camera sensor using the I2C bus for control and the CSI-2 bus for data. This driver supports following features: - manual exposure and analog/digital gain control support - vblank/hblank control support - t