Re: [PATCH for v5.3] v4l2-subdev: fix regression in check_pad()

2019-07-01 Thread Janusz Krzysztofik
Hi Sakari, On Monday, July 1, 2019 9:50:55 A.M. CEST Sakari Ailus wrote: > Hi Hans, > > On Sat, Jun 29, 2019 at 03:08:23PM +0200, Hans Verkuil wrote: > > On 6/29/19 2:57 PM, Hans Verkuil wrote: > > > On 6/29/19 2:06 PM, Janusz Krzysztofik wrote: > > >> Hi Hans, > > >> > > >> On Saturday, June 29

Re: [PATCH for v5.3] v4l2-subdev: fix regression in check_pad()

2019-07-01 Thread Sakari Ailus
Hi Hans, On Sat, Jun 29, 2019 at 03:08:23PM +0200, Hans Verkuil wrote: > On 6/29/19 2:57 PM, Hans Verkuil wrote: > > On 6/29/19 2:06 PM, Janusz Krzysztofik wrote: > >> Hi Hans, > >> > >> On Saturday, June 29, 2019 12:00:24 P.M. CEST Hans Verkuil wrote: > >>> sd->entity.graph_obj.mdev can be NULL w

Re: [PATCH for v5.3] v4l2-subdev: fix regression in check_pad()

2019-06-29 Thread Hans Verkuil
On 6/29/19 3:13 PM, Janusz Krzysztofik wrote: > On Saturday, June 29, 2019 2:57:09 P.M. CEST Hans Verkuil wrote: >> On 6/29/19 2:06 PM, Janusz Krzysztofik wrote: >>> Hi Hans, >>> >>> On Saturday, June 29, 2019 12:00:24 P.M. CEST Hans Verkuil wrote: sd->entity.graph_obj.mdev can be NULL when th

Re: [PATCH for v5.3] v4l2-subdev: fix regression in check_pad()

2019-06-29 Thread Janusz Krzysztofik
On Saturday, June 29, 2019 2:57:09 P.M. CEST Hans Verkuil wrote: > On 6/29/19 2:06 PM, Janusz Krzysztofik wrote: > > Hi Hans, > > > > On Saturday, June 29, 2019 12:00:24 P.M. CEST Hans Verkuil wrote: > >> sd->entity.graph_obj.mdev can be NULL when this function is called, and > >> that breaks exis

Re: [PATCH for v5.3] v4l2-subdev: fix regression in check_pad()

2019-06-29 Thread Hans Verkuil
On 6/29/19 2:57 PM, Hans Verkuil wrote: > On 6/29/19 2:06 PM, Janusz Krzysztofik wrote: >> Hi Hans, >> >> On Saturday, June 29, 2019 12:00:24 P.M. CEST Hans Verkuil wrote: >>> sd->entity.graph_obj.mdev can be NULL when this function is called, and >>> that breaks existing drivers (rcar-vin, but pro

[PATCH for v5.3] v4l2-subdev: fix regression in check_pad()

2019-06-29 Thread Hans Verkuil
sd->entity.graph_obj.mdev can be NULL when this function is called, and that breaks existing drivers (rcar-vin, but probably others as well). Check if sd->entity.num_pads is non-zero instead since that doesn't depend on mdev. Signed-off-by: Hans Verkuil Reported-by: Niklas Söderlund Fixes: a8fa

Re: [PATCH for v5.3] v4l2-subdev: fix regression in check_pad()

2019-06-29 Thread Hans Verkuil
On 6/29/19 2:06 PM, Janusz Krzysztofik wrote: > Hi Hans, > > On Saturday, June 29, 2019 12:00:24 P.M. CEST Hans Verkuil wrote: >> sd->entity.graph_obj.mdev can be NULL when this function is called, and >> that breaks existing drivers (rcar-vin, but probably others as well). >> >> Check if sd->enti

Re: [PATCH for v5.3] v4l2-subdev: fix regression in check_pad()

2019-06-29 Thread Janusz Krzysztofik
Hi Hans, On Saturday, June 29, 2019 12:00:24 P.M. CEST Hans Verkuil wrote: > sd->entity.graph_obj.mdev can be NULL when this function is called, and > that breaks existing drivers (rcar-vin, but probably others as well). > > Check if sd->entity.num_pads is non-zero instead since that doesn't depe

Re: [PATCH for v5.3] v4l2-subdev: fix regression in check_pad()

2019-06-29 Thread Niklas Söderlund
Hi Hans, Thanks for your work. On 2019-06-29 12:00:24 +0200, Hans Verkuil wrote: > sd->entity.graph_obj.mdev can be NULL when this function is called, and > that breaks existing drivers (rcar-vin, but probably others as well). > > Check if sd->entity.num_pads is non-zero instead since that doesn

[PATCH for v5.3] v4l2-subdev: fix regression in check_pad()

2019-06-29 Thread Hans Verkuil
sd->entity.graph_obj.mdev can be NULL when this function is called, and that breaks existing drivers (rcar-vin, but probably others as well). Check if sd->entity.num_pads is non-zero instead since that doesn't depend on mdev. Signed-off-by: Hans Verkuil Reported-by: Niklas Söderlund Fixes: a8fa