Re: [PATCH for v3.17] v4l2-ioctl: don't set PRIV_MAGIC unconditionally in g_fmt()

2014-07-21 Thread Hans Verkuil
On 07/21/2014 11:11 AM, Laurent Pinchart wrote: > Hi Hans, > > Thank you for the patch. > > On Sunday 20 July 2014 15:10:03 Hans Verkuil wrote: >> Regression fix: >> >> V4L2_PIX_FMT_PRIV_MAGIC should only be set for the VIDEO_CAPTURE and >> VIDEO_OUTPUT buffer types, and not for any others. In th

Re: [PATCH for v3.17] v4l2-ioctl: don't set PRIV_MAGIC unconditionally in g_fmt()

2014-07-21 Thread Laurent Pinchart
Hi Hans, Thank you for the patch. On Sunday 20 July 2014 15:10:03 Hans Verkuil wrote: > Regression fix: > > V4L2_PIX_FMT_PRIV_MAGIC should only be set for the VIDEO_CAPTURE and > VIDEO_OUTPUT buffer types, and not for any others. In the case of > the win format this overwrites a pointer value th

[PATCH for v3.17] v4l2-ioctl: don't set PRIV_MAGIC unconditionally in g_fmt()

2014-07-20 Thread Hans Verkuil
Regression fix: V4L2_PIX_FMT_PRIV_MAGIC should only be set for the VIDEO_CAPTURE and VIDEO_OUTPUT buffer types, and not for any others. In the case of the win format this overwrites a pointer value that is passed in from userspace. Since it is already set for the VIDEO_CAPTURE and VIDEO_OUTPUT ca