Re: [PATCH V3 1/2] bdisp: Fix a possible sleep-in-atomic bug in bdisp_hw_reset

2017-12-19 Thread Fabien DESSENNE
Hi, It's almost good! You have to fix these checkpatch Warning/Check: WARNING: Block comments use a trailing */ on a separate line #36: FILE: drivers/media/platform/sti/bdisp/bdisp-hw.c:383: +     * needing any delays */ CHECK: Alignment should match open parenthesis #38: FILE: drivers/media/p

[PATCH V3 1/2] bdisp: Fix a possible sleep-in-atomic bug in bdisp_hw_reset

2017-12-19 Thread Jia-Ju Bai
The driver may sleep under a spinlock. The function call path is: bdisp_device_run (acquire the spinlock) bdisp_hw_reset msleep --> may sleep To fix it, readl_poll_timeout_atomic is used to replace msleep. This bug is found by my static analysis tool(DSAC) and checked by my code review. Si