Re: [PATCH V2 08/13] cx231xx: remember status of i2c port_3 switch

2014-10-01 Thread Matthias Schwarzott
On 01.10.2014 21:36, Antti Palosaari wrote: > I don't understand that patch. Commit message should explain it likely > better details. > > You added flag 'port_3_switch_enabled' to device state. That is for I2C > mux, but what it means? Does it means mux is currently switched to to > port 3? Later

Re: [PATCH V2 08/13] cx231xx: remember status of i2c port_3 switch

2014-10-01 Thread Antti Palosaari
I don't understand that patch. Commit message should explain it likely better details. You added flag 'port_3_switch_enabled' to device state. That is for I2C mux, but what it means? Does it means mux is currently switched to to port 3? Later you will use that flag to avoid unnecessary mux swi

[PATCH V2 08/13] cx231xx: remember status of i2c port_3 switch

2014-09-30 Thread Matthias Schwarzott
If remembering is not stable enough, this must be changed to query from the register when needed. Signed-off-by: Matthias Schwarzott --- drivers/media/usb/cx231xx/cx231xx-avcore.c | 3 +++ drivers/media/usb/cx231xx/cx231xx.h| 1 + 2 files changed, 4 insertions(+) diff --git a/drivers/m