Re: [PATCH RFC] media: staging/imx: fix complete handler

2017-10-03 Thread Steve Longerbeam
On 10/03/2017 02:06 AM, Russell King - ARM Linux wrote: On Mon, Oct 02, 2017 at 05:59:30PM -0700, Steve Longerbeam wrote: On 10/01/2017 04:36 PM, Russell King - ARM Linux wrote: On Sun, Oct 01, 2017 at 01:16:53PM -0700, Steve Longerbeam wrote: Right, imx_media_add_vdev_to_pa() has followed a

Re: [PATCH RFC] media: staging/imx: fix complete handler

2017-10-03 Thread Russell King - ARM Linux
On Mon, Oct 02, 2017 at 05:59:30PM -0700, Steve Longerbeam wrote: > > > On 10/01/2017 04:36 PM, Russell King - ARM Linux wrote: > >On Sun, Oct 01, 2017 at 01:16:53PM -0700, Steve Longerbeam wrote: > >>Right, imx_media_add_vdev_to_pa() has followed a link to an > >>entity that imx is not aware of.

Re: [PATCH RFC] media: staging/imx: fix complete handler

2017-10-02 Thread Steve Longerbeam
On 10/01/2017 04:36 PM, Russell King - ARM Linux wrote: On Sun, Oct 01, 2017 at 01:16:53PM -0700, Steve Longerbeam wrote: Right, imx_media_add_vdev_to_pa() has followed a link to an entity that imx is not aware of. The only effect of this patch (besides allowing the driver to load with smiapp

Re: [PATCH RFC] media: staging/imx: fix complete handler

2017-10-01 Thread Russell King - ARM Linux
On Sun, Oct 01, 2017 at 01:16:53PM -0700, Steve Longerbeam wrote: > Right, imx_media_add_vdev_to_pa() has followed a link to an > entity that imx is not aware of. > > The only effect of this patch (besides allowing the driver to load > with smiapp cameras), is that no controls from the unknown ent

Re: [PATCH RFC] media: staging/imx: fix complete handler

2017-10-01 Thread Steve Longerbeam
Hi Russell, On 09/29/2017 02:38 PM, Russell King wrote: The complete handler walks all entities, expecting to find an imx subdevice for each and every entity. However, camera drivers such as smiapp can themselves contain multiple entities, for which there will not be an imx subdevice. This ca

Re: [PATCH RFC] media: staging/imx: fix complete handler

2017-09-30 Thread Mauro Carvalho Chehab
Em Fri, 29 Sep 2017 22:38:39 +0100 Russell King escreveu: > The complete handler walks all entities, expecting to find an imx > subdevice for each and every entity. > > However, camera drivers such as smiapp can themselves contain multiple > entities, for which there will not be an imx subdevice

[PATCH RFC] media: staging/imx: fix complete handler

2017-09-29 Thread Russell King
The complete handler walks all entities, expecting to find an imx subdevice for each and every entity. However, camera drivers such as smiapp can themselves contain multiple entities, for which there will not be an imx subdevice. This causes imx_media_find_subdev_by_sd() to fail, making the imx c