Re: [PATCH RFC] [media] blackfin: add video display driver

2013-04-25 Thread Sylwester Nawrocki
Hi Scott, On 04/24/2013 11:26 AM, Scott Jiang wrote: + struct v4l2_device v4l2_dev; + /* v4l2 control handler */ + struct v4l2_ctrl_handler ctrl_handler; This handler seems to be unused, I couldn't find any code adding controls to it. Any initialization of this handler is

Re: [PATCH RFC] [media] blackfin: add video display driver

2013-04-24 Thread Scott Jiang
Hi Sylwester, > >> + struct v4l2_device v4l2_dev; >> + /* v4l2 control handler */ >> + struct v4l2_ctrl_handler ctrl_handler; > > > This handler seems to be unused, I couldn't find any code adding controls > to it. Any initialization of this handler is a dead code now. You probab

Re: [PATCH RFC] [media] blackfin: add video display driver

2013-04-18 Thread Sylwester Nawrocki
Hi Scott, On 04/17/2013 08:57 AM, Scott Jiang wrote: Hi Sylwester , @@ -9,7 +9,18 @@ config VIDEO_BLACKFIN_CAPTURE To compile this driver as a module, choose M here: the module will be called bfin_capture. +config VIDEO_BLACKFIN_DISPLAY + tristate "Blackfin Video D

Re: [PATCH RFC] [media] blackfin: add video display driver

2013-04-16 Thread Scott Jiang
Hi Sylwester , >> @@ -9,7 +9,18 @@ config VIDEO_BLACKFIN_CAPTURE >> To compile this driver as a module, choose M here: the >> module will be called bfin_capture. >> >> +config VIDEO_BLACKFIN_DISPLAY >> + tristate "Blackfin Video Display Driver" >> + depends on VIDEO

Re: [PATCH RFC] [media] blackfin: add video display driver

2013-04-16 Thread Scott Jiang
Hi Hans, >> +/* >> + * Analog Devices video display driver >> + * >> + * Copyright (c) 2011 Analog Devices Inc. > > Analog Devices? What has this to do with Analog Devices? > I wrote this driver for Analog Devices Blackfin. >> + >> +static int disp_mmap(struct file *file, struct vm_area_struct *

Re: [PATCH RFC] [media] blackfin: add video display driver

2013-04-15 Thread Hans Verkuil
Hi Scott! On Sat April 13 2013 01:52:58 Scott Jiang wrote: > This is a bridge driver for blackfin diplay device. > It can work with ppi or eppi interface. DV timings > are supported. Thanks for the patch. There are a number of comments below. For the most part you can save a lot of code by making

Re: [PATCH RFC] [media] blackfin: add video display driver

2013-04-12 Thread Sylwester Nawrocki
Hello, On 04/13/2013 01:52 AM, Scott Jiang wrote: This is a bridge driver for blackfin diplay device. It can work with ppi or eppi interface. DV timings are supported. Signed-off-by: Scott Jiang --- drivers/media/platform/blackfin/Kconfig| 15 +- drivers/media/platform/blackfin/Mak

[PATCH RFC] [media] blackfin: add video display driver

2013-04-12 Thread Scott Jiang
This is a bridge driver for blackfin diplay device. It can work with ppi or eppi interface. DV timings are supported. Signed-off-by: Scott Jiang --- drivers/media/platform/blackfin/Kconfig| 15 +- drivers/media/platform/blackfin/Makefile |1 + drivers/media/platform/blackfin/