On Wed 11 July 2012 16:19:02 Federico Vaga wrote:
> > > > @@ -445,9 +402,9 @@ static const struct v4l2_subdev_video_ops
> > > > adv7180_video_ops = {>
> > > > static const struct v4l2_subdev_core_ops adv7180_core_ops = {
> > > >
> > > > .g_chip_ident = adv7180_g_chip_ident,
> > > > .s_std =
> > > @@ -445,9 +402,9 @@ static const struct v4l2_subdev_video_ops
> > > adv7180_video_ops = {>
> > > static const struct v4l2_subdev_core_ops adv7180_core_ops = {
> > >
> > > .g_chip_ident = adv7180_g_chip_ident,
> > > .s_std = adv7180_s_std,
> > >
> > > - .queryctrl = adv7180_queryctrl,
On Wed 11 July 2012 15:36:25 Federico Vaga wrote:
> Hi Hans,
>
> Thank you for your review
>
> > > +static int adv7180_init_controls(struct adv7180_state *state)
> > > +{
> > > + v4l2_ctrl_handler_init(&state->ctrl_hdl, 2);
> >
> > 2 -> 4, since there are 4 controls. It's a hint only, but it hel
Hi Hans,
Thank you for your review
> > +static int adv7180_init_controls(struct adv7180_state *state)
> > +{
> > + v4l2_ctrl_handler_init(&state->ctrl_hdl, 2);
>
> 2 -> 4, since there are 4 controls. It's a hint only, but it helps
> optimizing the internal hash data structure.
Sure :)
> >
>
Hi Federico!
A few small remarks:
On Wed July 11 2012 04:34:46 Federico Vaga wrote:
> Signed-off-by: Federico Vaga
> ---
> drivers/media/video/adv7180.c | 221
> +
> 1 file changed, 90 insertions(+), 131 deletions(-)
>
> diff --git a/drivers/media/vide
Signed-off-by: Federico Vaga
---
drivers/media/video/adv7180.c | 221 +
1 file changed, 90 insertions(+), 131 deletions(-)
diff --git a/drivers/media/video/adv7180.c b/drivers/media/video/adv7180.c
index 174bffa..7705456 100644
--- a/drivers/media/video/a
