Re: [PATCH 7/8] IR: extend ir_raw_event and do refactoring

2010-10-14 Thread Jarod Wilson
On Tue, Sep 07, 2010 at 12:26:12AM +0300, Maxim Levitsky wrote: > Add new event types for timeout & carrier report > Move timeout handling from ir_raw_event_store_with_filter to > ir-lirc-codec, where it is really needed. > Now lirc bridge ensures proper gap handling. > Extend lirc bridge for carri

Re: [PATCH 7/8] IR: extend ir_raw_event and do refactoring

2010-09-08 Thread Mauro Carvalho Chehab
Em 08-09-2010 20:02, Andy Walls escreveu: > On Wed, 2010-09-08 at 13:27 -0400, Jarod Wilson wrote: I'd be inclined to simply move duty_cycle out of the union and leave just duration and carrier in it. >>> >>> That's not necessary and it could be confusing depending on where you >>

Re: [PATCH 7/8] IR: extend ir_raw_event and do refactoring

2010-09-08 Thread David Härdeman
On Wed, Sep 08, 2010 at 07:02:33PM -0400, Andy Walls wrote: > On Wed, 2010-09-08 at 13:27 -0400, Jarod Wilson wrote: > > On Wed, Sep 08, 2010 at 12:50:46PM -0400, Andy Walls wrote: > > > On Wed, 2010-09-08 at 11:26 -0400, Jarod Wilson wrote: > > > > On Mon, Sep 6, 2010 at 5:26 PM, Maxim Levitsky >

Re: [PATCH 7/8] IR: extend ir_raw_event and do refactoring

2010-09-08 Thread Andy Walls
On Wed, 2010-09-08 at 13:27 -0400, Jarod Wilson wrote: > On Wed, Sep 08, 2010 at 12:50:46PM -0400, Andy Walls wrote: > > On Wed, 2010-09-08 at 11:26 -0400, Jarod Wilson wrote: > > > On Mon, Sep 6, 2010 at 5:26 PM, Maxim Levitsky > > > wrote: > > > > > > I'm generally good with this entire patch

Re: [PATCH 7/8] IR: extend ir_raw_event and do refactoring

2010-09-08 Thread Mauro Carvalho Chehab
Em 08-09-2010 19:49, David Härdeman escreveu: > On Wed, Sep 08, 2010 at 07:42:04PM -0300, Mauro Carvalho Chehab wrote: >> Em 06-09-2010 18:26, Maxim Levitsky escreveu: >>> diff --git a/drivers/media/IR/ir-rc6-decoder.c >>> b/drivers/media/IR/ir-rc6-decoder.c >>> index f1624b8..d25da91 100644 >>> -

Re: [PATCH 7/8] IR: extend ir_raw_event and do refactoring

2010-09-08 Thread David Härdeman
On Wed, Sep 08, 2010 at 07:42:04PM -0300, Mauro Carvalho Chehab wrote: > Em 06-09-2010 18:26, Maxim Levitsky escreveu: > > Add new event types for timeout & carrier report > > Move timeout handling from ir_raw_event_store_with_filter to > > ir-lirc-codec, where it is really needed. > > Now lirc bri

Re: [PATCH 7/8] IR: extend ir_raw_event and do refactoring

2010-09-08 Thread Mauro Carvalho Chehab
Em 06-09-2010 18:26, Maxim Levitsky escreveu: > Add new event types for timeout & carrier report > Move timeout handling from ir_raw_event_store_with_filter to > ir-lirc-codec, where it is really needed. > Now lirc bridge ensures proper gap handling. > Extend lirc bridge for carrier & timeout repor

Re: [PATCH 7/8] IR: extend ir_raw_event and do refactoring

2010-09-08 Thread Jarod Wilson
On Wed, Sep 08, 2010 at 12:50:46PM -0400, Andy Walls wrote: > On Wed, 2010-09-08 at 11:26 -0400, Jarod Wilson wrote: > > On Mon, Sep 6, 2010 at 5:26 PM, Maxim Levitsky > > wrote: > > > Add new event types for timeout & carrier report > > > Move timeout handling from ir_raw_event_store_with_filter

Re: [PATCH 7/8] IR: extend ir_raw_event and do refactoring

2010-09-08 Thread Andy Walls
On Wed, 2010-09-08 at 11:26 -0400, Jarod Wilson wrote: > On Mon, Sep 6, 2010 at 5:26 PM, Maxim Levitsky > wrote: > > Add new event types for timeout & carrier report > > Move timeout handling from ir_raw_event_store_with_filter to > > ir-lirc-codec, where it is really needed. > > Now lirc bridge

Re: [PATCH 7/8] IR: extend ir_raw_event and do refactoring

2010-09-08 Thread Jarod Wilson
On Mon, Sep 6, 2010 at 5:26 PM, Maxim Levitsky wrote: > Add new event types for timeout & carrier report > Move timeout handling from ir_raw_event_store_with_filter to > ir-lirc-codec, where it is really needed. > Now lirc bridge ensures proper gap handling. > Extend lirc bridge for carrier & time

[PATCH 7/8] IR: extend ir_raw_event and do refactoring

2010-09-06 Thread Maxim Levitsky
Add new event types for timeout & carrier report Move timeout handling from ir_raw_event_store_with_filter to ir-lirc-codec, where it is really needed. Now lirc bridge ensures proper gap handling. Extend lirc bridge for carrier & timeout reports Note: all new ir_raw_event variables now should be i

Re: [PATCH 7/8] IR: extend ir_raw_event and do refactoring

2010-09-05 Thread Maxim Levitsky
On Sun, 2010-09-05 at 23:23 +0200, David Härdeman wrote: > Comments inline... > > On Sun, Sep 05, 2010 at 02:23:02AM +0300, Maxim Levitsky wrote: > > Add new event types for timeout & carrier report > > Move timeout handling from ir_raw_event_store_with_filter to > > ir-lirc-codec, where it is re

Re: [PATCH 7/8] IR: extend ir_raw_event and do refactoring

2010-09-05 Thread David Härdeman
Comments inline... On Sun, Sep 05, 2010 at 02:23:02AM +0300, Maxim Levitsky wrote: > Add new event types for timeout & carrier report > Move timeout handling from ir_raw_event_store_with_filter to > ir-lirc-codec, where it is really needed. > Now lirc bridge ensures proper gap handling. > Extend l