Re: [PATCH 6/8] WmT: adv7604 driver compatibility

2015-02-03 Thread Laurent Pinchart
On Tuesday 03 February 2015 16:29:57 Lars-Peter Clausen wrote: > On 02/03/2015 04:24 PM, Hans Verkuil wrote: > > On 02/03/15 16:22, Laurent Pinchart wrote: [snip] > >> I can't help you much with that, but I could test changes using the > >> rcar-vin driver with the adv7180 if needed (does the adv

Re: [PATCH 6/8] WmT: adv7604 driver compatibility

2015-02-03 Thread Laurent Pinchart
Hi Hans, On Tuesday 03 February 2015 16:24:19 Hans Verkuil wrote: > On 02/03/15 16:22, Laurent Pinchart wrote: > > On Monday 02 February 2015 11:09:27 Hans Verkuil wrote: > >> On 02/02/2015 11:01 AM, Laurent Pinchart wrote: > >>> On Sunday 01 February 2015 12:26:11 Guennadi Liakhovetski wrote: > >

Re: [PATCH 6/8] WmT: adv7604 driver compatibility

2015-02-03 Thread Lars-Peter Clausen
On 02/03/2015 04:24 PM, Hans Verkuil wrote: On 02/03/15 16:22, Laurent Pinchart wrote: Hi Hans, On Monday 02 February 2015 11:09:27 Hans Verkuil wrote: On 02/02/2015 11:01 AM, Laurent Pinchart wrote: On Sunday 01 February 2015 12:26:11 Guennadi Liakhovetski wrote: On a second thought: On Su

Re: [PATCH 6/8] WmT: adv7604 driver compatibility

2015-02-03 Thread Hans Verkuil
On 02/03/15 16:22, Laurent Pinchart wrote: > Hi Hans, > > On Monday 02 February 2015 11:09:27 Hans Verkuil wrote: >> On 02/02/2015 11:01 AM, Laurent Pinchart wrote: >>> On Sunday 01 February 2015 12:26:11 Guennadi Liakhovetski wrote: On a second thought: On Sun, 1 Feb 2015, Guennadi

Re: [PATCH 6/8] WmT: adv7604 driver compatibility

2015-02-03 Thread Laurent Pinchart
Hi Hans, On Monday 02 February 2015 11:09:27 Hans Verkuil wrote: > On 02/02/2015 11:01 AM, Laurent Pinchart wrote: > > On Sunday 01 February 2015 12:26:11 Guennadi Liakhovetski wrote: > >> On a second thought: > >> > >> On Sun, 1 Feb 2015, Guennadi Liakhovetski wrote: > >>> Hi Wills, > >>> > >>>

Re: [PATCH 6/8] WmT: adv7604 driver compatibility

2015-02-02 Thread Hans Verkuil
On 02/02/2015 11:01 AM, Laurent Pinchart wrote: > Hi Guennadi, > > On Sunday 01 February 2015 12:26:11 Guennadi Liakhovetski wrote: >> On a second thought: >> >> On Sun, 1 Feb 2015, Guennadi Liakhovetski wrote: >>> Hi Wills, >>> >>> Thanks for the patch. First and foremost, the title of the patch

Re: [PATCH 6/8] WmT: adv7604 driver compatibility

2015-02-02 Thread Laurent Pinchart
Hi Guennadi, On Sunday 01 February 2015 12:26:11 Guennadi Liakhovetski wrote: > On a second thought: > > On Sun, 1 Feb 2015, Guennadi Liakhovetski wrote: > > Hi Wills, > > > > Thanks for the patch. First and foremost, the title of the patch is wrong. > > This patch does more than just adding som

Re: [PATCH 6/8] WmT: adv7604 driver compatibility

2015-02-01 Thread Guennadi Liakhovetski
On a second thought: On Sun, 1 Feb 2015, Guennadi Liakhovetski wrote: > Hi Wills, > > Thanks for the patch. First and foremost, the title of the patch is wrong. > This patch does more than just adding some "adv7604 compatibility." It's > adding pad-level API to soc-camera. > > This is just a

Re: [PATCH 6/8] WmT: adv7604 driver compatibility

2015-01-31 Thread Guennadi Liakhovetski
Hi Wills, Thanks for the patch. First and foremost, the title of the patch is wrong. This patch does more than just adding some "adv7604 compatibility." It's adding pad-level API to soc-camera. This is just a rough review. I'm not an expert in media-controller / pad-level API, I hope someone w

[PATCH 6/8] WmT: adv7604 driver compatibility

2015-01-29 Thread William Towle
Add 'struct media_pad pad' member and suitable glue code, so that soc_camera/rcar_vin can become agnostic to whether an old or new- style driver (wrt pad API use) can sit underneath This version has been reworked to include appropriate constant and datatype names for kernel v3.18 --- drivers/medi