Re: [PATCH 54/57] [media] platform: don't break long lines

2016-10-17 Thread Andrey Utkin
On Mon, Oct 17, 2016 at 09:44:19PM +0300, Laurent Pinchart wrote: > Hi Andrey, > > On Monday 17 Oct 2016 20:39:45 Andrey Utkin wrote: > > Maybe the remaining manual work may be outsourced to seekers of janitor > > tasks? > > I'm fine with that, but we should rework the original patches, not merge

Re: [PATCH 54/57] [media] platform: don't break long lines

2016-10-17 Thread Laurent Pinchart
Hi Andrey, On Monday 17 Oct 2016 20:39:45 Andrey Utkin wrote: > On Mon, Oct 17, 2016 at 04:45:06PM +0300, Laurent Pinchart wrote: > > If you really want to perform such a change, let's not make lines > > unnecessarily long either. You should add a line break after the first and > > > > second arg

Re: [PATCH 54/57] [media] platform: don't break long lines

2016-10-17 Thread Andrey Utkin
On Mon, Oct 17, 2016 at 04:45:06PM +0300, Laurent Pinchart wrote: > If you really want to perform such a change, let's not make lines > unnecessarily long either. You should add a line break after the first and > second argument: > > dprintk(ctx->dev, > "%s da

Re: [PATCH 54/57] [media] platform: don't break long lines

2016-10-17 Thread Laurent Pinchart
Hi Mauro, Thank you for the patch. On Friday 14 Oct 2016 17:20:42 Mauro Carvalho Chehab wrote: > Due to the 80-cols checkpatch warnings, several strings > were broken into multiple lines. This is not considered > a good practice anymore, as it makes harder to grep for > strings at the source code

Re: [PATCH 54/57] [media] platform: don't break long lines

2016-10-14 Thread Robert Jarzmik
Mauro Carvalho Chehab writes: > Due to the 80-cols checkpatch warnings, several strings > were broken into multiple lines. This is not considered > a good practice anymore, as it makes harder to grep for > strings at the source code. So, join those continuation > lines. > > Signed-off-by: Mauro C

[PATCH 54/57] [media] platform: don't break long lines

2016-10-14 Thread Mauro Carvalho Chehab
Due to the 80-cols checkpatch warnings, several strings were broken into multiple lines. This is not considered a good practice anymore, as it makes harder to grep for strings at the source code. So, join those continuation lines. Signed-off-by: Mauro Carvalho Chehab --- drivers/media/platform/m