Re: [PATCH 5/5] [media] media-device: make media_device_cleanup() static

2016-03-22 Thread Shuah Khan
On 03/16/2016 06:04 AM, Mauro Carvalho Chehab wrote: > When multiple drivers are sharing the media_device struct, > one driver cannot know the right moment to cleanup the > media_device struct, because it can happen only when the > struct is not used by the other drivers. > > So, let's call media_

Re: [PATCH 5/5] [media] media-device: make media_device_cleanup() static

2016-03-20 Thread Mauro Carvalho Chehab
Em Wed, 16 Mar 2016 11:03:38 -0300 Javier Martinez Canillas escreveu: > Hello Mauro, > > The patch looks mostly good to me, I just have a question below: > > On Wed, Mar 16, 2016 at 9:04 AM, Mauro Carvalho Chehab > wrote: > > [snip] > > > > > -void media_device_cleanup(struct media_device *m

[PATCH 5/5] [media] media-device: make media_device_cleanup() static

2016-03-19 Thread Mauro Carvalho Chehab
When multiple drivers are sharing the media_device struct, one driver cannot know the right moment to cleanup the media_device struct, because it can happen only when the struct is not used by the other drivers. So, let's call media_device_cleanup() internally, and ensure that media_device_unregis

Re: [PATCH 5/5] [media] media-device: make media_device_cleanup() static

2016-03-19 Thread Javier Martinez Canillas
Hello Mauro, On Wed, Mar 16, 2016 at 11:36 AM, Mauro Carvalho Chehab wrote: > Em Wed, 16 Mar 2016 11:03:38 -0300 > Javier Martinez Canillas escreveu: > >> Hello Mauro, >> >> The patch looks mostly good to me, I just have a question below: >> >> On Wed, Mar 16, 2016 at 9:04 AM, Mauro Carvalho Che

Re: [PATCH 5/5] [media] media-device: make media_device_cleanup() static

2016-03-18 Thread Javier Martinez Canillas
Hello Mauro, The patch looks mostly good to me, I just have a question below: On Wed, Mar 16, 2016 at 9:04 AM, Mauro Carvalho Chehab wrote: [snip] > > -void media_device_cleanup(struct media_device *mdev) > +static void media_device_cleanup(struct media_device *mdev) > { > ida_destroy