Hello Hans,
On 09/26/2011 04:25 PM, Hans Verkuil wrote:
> On Wednesday, September 14, 2011 16:30:47 Sylwester Nawrocki wrote:
>> On 09/14/2011 09:10 AM, Scott Jiang wrote:
> +static int bcap_qbuf(struct file *file, void *priv,
> + struct v4l2_buffer *buf)
> +{
>
On Wednesday, September 14, 2011 16:30:47 Sylwester Nawrocki wrote:
> On 09/14/2011 09:10 AM, Scott Jiang wrote:
> >>> +static int bcap_qbuf(struct file *file, void *priv,
> >>> + struct v4l2_buffer *buf)
> >>> +{
> >>> + struct bcap_device *bcap_dev = video_drvdata(file);
>
One more clean-up possibility:
On Tue, 13 Sep 2011, Scott Jiang wrote:
> this is a v4l2 bridge driver for Blackfin video capture device,
> support ppi interface
>
> Signed-off-by: Scott Jiang
> ---
[snip]
> diff --git a/drivers/media/video/blackfin/bfin_capture.c
> b/drivers/media/video/blac
On Fri, 16 Sep 2011, Scott Jiang wrote:
> 2011/9/13 Guennadi Liakhovetski :
> > On Tue, 13 Sep 2011, Scott Jiang wrote:
> >
> >> >> +
> >> >> +struct bcap_format {
> >> >> + u8 *desc;
> >> >> + u32 pixelformat;
> >> >> + enum v4l2_mbus_pixelcode mbus_code;
> >> >> + int bpp; /* byt
2011/9/13 Guennadi Liakhovetski :
> On Tue, 13 Sep 2011, Scott Jiang wrote:
>
>> >> +
>> >> +struct bcap_format {
>> >> + u8 *desc;
>> >> + u32 pixelformat;
>> >> + enum v4l2_mbus_pixelcode mbus_code;
>> >> + int bpp; /* bytes per pixel */
>> >
>> > Don't you think you might have to
On Fri, 16 Sep 2011, Scott Jiang wrote:
> 2011/9/16 Sylwester Nawrocki :
> > On 09/15/2011 04:40 AM, Scott Jiang wrote:
> >> 2011/9/14 Sylwester Nawrocki:
> >>> On 09/14/2011 09:10 AM, Scott Jiang wrote:
>
> >> + fmt =&bcap_formats[i];
> >> + if
2011/9/16 Sylwester Nawrocki :
> On 09/15/2011 04:40 AM, Scott Jiang wrote:
>> 2011/9/14 Sylwester Nawrocki:
>>> On 09/14/2011 09:10 AM, Scott Jiang wrote:
>> + fmt =&bcap_formats[i];
>> + if (mbus_code)
>> + *mbus
On 09/15/2011 04:40 AM, Scott Jiang wrote:
> 2011/9/14 Sylwester Nawrocki:
>> On 09/14/2011 09:10 AM, Scott Jiang wrote:
>>>
> + fmt =&bcap_formats[i];
> + if (mbus_code)
> + *mbus_code = fmt->mbus_code;
> +
On 09/15/2011 08:37 AM, Scott Jiang wrote:
>>
>>> +
>>> +#define CAPTURE_DRV_NAME"bfin_capture"
>>> +#define BCAP_MIN_NUM_BUF2
>>> +
>>> +struct bcap_format {
>>> + u8 *desc;
>>> + u32 pixelformat;
>>> + enum v4l2_mbus_pixelcode mbus_code;
>>> + int bpp; /* bytes per
On Thu, 15 Sep 2011, Scott Jiang wrote:
> >> I have considered using soc, but it can't support decoder when I began
> >> to write this driver in 2.6.38.
> >
> > soc_mediabus.c is a stand-alone module, it has no dependencies on
> > soc-camera.
> >
> > Out of interest - what kind of decoder you mean
>> I have considered using soc, but it can't support decoder when I began
>> to write this driver in 2.6.38.
>
> soc_mediabus.c is a stand-alone module, it has no dependencies on
> soc-camera.
>
> Out of interest - what kind of decoder you mean? A tv-decoder? We do have
> a tv-decoder driver tw9910
On Thu, 15 Sep 2011, Scott Jiang wrote:
> 2011/9/15 Guennadi Liakhovetski :
> > On Thu, 15 Sep 2011, Scott Jiang wrote:
> >
> >> accually this array is to convert mbus to pixformat. ppi supports any
> >> formats.
> >
> > You mean, it doesn't distinguish formats? It just packs bytes in RAM
> > exa
2011/9/15 Guennadi Liakhovetski :
> On Thu, 15 Sep 2011, Scott Jiang wrote:
>
>> accually this array is to convert mbus to pixformat. ppi supports any
>> formats.
>
> You mean, it doesn't distinguish formats? It just packs bytes in RAM
> exactly as it ready them from the bus, and doesn't support a
>
>> +
>> +#define CAPTURE_DRV_NAME "bfin_capture"
>> +#define BCAP_MIN_NUM_BUF 2
>> +
>> +struct bcap_format {
>> + u8 *desc;
>> + u32 pixelformat;
>> + enum v4l2_mbus_pixelcode mbus_code;
>> + int bpp; /* bytes per pixel */
>
> Don't you think you might have to proce
On Thu, 15 Sep 2011, Scott Jiang wrote:
> accually this array is to convert mbus to pixformat. ppi supports any formats.
You mean, it doesn't distinguish formats? It just packs bytes in RAM
exactly as it ready them from the bus, and doesn't support any formats
natively, i.e., doesn't offer any
2011/9/14 Sylwester Nawrocki :
> On 09/14/2011 09:10 AM, Scott Jiang wrote:
+static int bcap_qbuf(struct file *file, void *priv,
+ struct v4l2_buffer *buf)
+{
+ struct bcap_device *bcap_dev = video_drvdata(file);
+ struct v4l2_fh *fh = file->priv
On 09/14/2011 09:10 AM, Scott Jiang wrote:
>>> +static int bcap_qbuf(struct file *file, void *priv,
>>> + struct v4l2_buffer *buf)
>>> +{
>>> + struct bcap_device *bcap_dev = video_drvdata(file);
>>> + struct v4l2_fh *fh = file->private_data;
>>> + struct bcap_fh *bc
On Wed, 14 Sep 2011, Scott Jiang wrote:
> > i think at least these three are unused and should get punted
> >
> >> +static int __devinit bcap_probe(struct platform_device *pdev)
> >> +{
> >> + struct bcap_device *bcap_dev;
> >> + struct video_device *vfd;
> >> + struct i2c_adapte
> i think at least these three are unused and should get punted
>
>> +static int __devinit bcap_probe(struct platform_device *pdev)
>> +{
>> + struct bcap_device *bcap_dev;
>> + struct video_device *vfd;
>> + struct i2c_adapter *i2c_adap;
>
> you need to include linux/i2c.h for th
>> +static int bcap_qbuf(struct file *file, void *priv,
>> + struct v4l2_buffer *buf)
>> +{
>> + struct bcap_device *bcap_dev = video_drvdata(file);
>> + struct v4l2_fh *fh = file->private_data;
>> + struct bcap_fh *bcap_fh = container_of(fh, struct bcap_fh, fh);
>>
>> > I think, the direct use of vb2_plane_cookie() is discouraged.
>> > vb2_dma_contig_plane_dma_addr() should work for you.
>> >
>> I guess you mean vb2_dma_contig_plane_paddr
>
> no, in the current kernel it's vb2_dma_contig_plane_dma_addr(). See
>
> http://git.linuxtv.org/media_tree.git/shortlog
On Tue, Sep 13, 2011 at 14:34, Scott Jiang wrote:
> --- /dev/null
> +++ b/drivers/media/video/blackfin/Kconfig
> @@ -0,0 +1,10 @@
> +config VIDEO_BLACKFIN_CAPTURE
> + tristate "Blackfin Video Capture Driver"
> + depends on VIDEO_DEV && BLACKFIN
> + select VIDEOBUF2_DMA_CONTIG
sin
Hi Scott,
On 09/13/2011 08:34 PM, Scott Jiang wrote:
> this is a v4l2 bridge driver for Blackfin video capture device,
> support ppi interface
>
> Signed-off-by: Scott Jiang
> ---
> drivers/media/video/Makefile|2 +
> drivers/media/video/blackfin/Kconfig| 10 +
>
On Tue, 13 Sep 2011, Scott Jiang wrote:
> >> +
> >> +struct bcap_format {
> >> + u8 *desc;
> >> + u32 pixelformat;
> >> + enum v4l2_mbus_pixelcode mbus_code;
> >> + int bpp; /* bytes per pixel */
> >
> > Don't you think you might have to process 12 bpp formats at some point,
> > li
>> +
>> +struct bcap_format {
>> + u8 *desc;
>> + u32 pixelformat;
>> + enum v4l2_mbus_pixelcode mbus_code;
>> + int bpp; /* bytes per pixel */
>
> Don't you think you might have to process 12 bpp formats at some point,
> like YUV 4:2:0, or NV12? Maybe better calculate in bits from
Again, no complete review, just a couple of remarks
On Tue, 13 Sep 2011, Scott Jiang wrote:
> this is a v4l2 bridge driver for Blackfin video capture device,
> support ppi interface
>
> Signed-off-by: Scott Jiang
> ---
[snip]
> diff --git a/drivers/media/video/blackfin/bfin_capture.c
> b/dri
this is a v4l2 bridge driver for Blackfin video capture device,
support ppi interface
Signed-off-by: Scott Jiang
---
drivers/media/video/Makefile|2 +
drivers/media/video/blackfin/Kconfig| 10 +
drivers/media/video/blackfin/Makefile |2 +
drivers/media/vid
27 matches
Mail list logo
