Re: [PATCH 4/4] pxa_camera: Fix overrun condition on last buffer

2009-03-12 Thread Guennadi Liakhovetski
On Thu, 12 Mar 2009, Robert Jarzmik wrote: > Guennadi Liakhovetski writes: > > >> diff --git a/drivers/media/video/pxa_camera.c > >> b/drivers/media/video/pxa_camera.c > >> index 16bf0a3..dd56c35 100644 > >> --- a/drivers/media/video/pxa_camera.c > >> +++ b/drivers/media/video/pxa_camera.c > >>

Re: [PATCH 4/4] pxa_camera: Fix overrun condition on last buffer

2009-03-12 Thread Robert Jarzmik
Guennadi Liakhovetski writes: >> diff --git a/drivers/media/video/pxa_camera.c >> b/drivers/media/video/pxa_camera.c >> index 16bf0a3..dd56c35 100644 >> --- a/drivers/media/video/pxa_camera.c >> +++ b/drivers/media/video/pxa_camera.c >> @@ -734,14 +734,18 @@ static void pxa_camera_dma_irq(int ch

Re: [PATCH 4/4] pxa_camera: Fix overrun condition on last buffer

2009-03-11 Thread Guennadi Liakhovetski
On Thu, 5 Mar 2009, Robert Jarzmik wrote: > The last buffer queued will often overrun, as the DMA chain > is finished, and the time the dma irq handler is activated, > the QIF fifos are filled by the sensor. > > The fix is to ignore the overrun condition on the last > queued buffer, and restart t

Re: [PATCH 4/4] pxa_camera: Fix overrun condition on last buffer

2009-03-09 Thread Robert Jarzmik
Guennadi Liakhovetski writes: > On Thu, 5 Mar 2009, Robert Jarzmik wrote: > >> The last buffer queued will often overrun, as the DMA chain >> is finished, and the time the dma irq handler is activated, > > s/and the time/and during the time/ ? If you wish, or might be simply "and before the dma i

Re: [PATCH 4/4] pxa_camera: Fix overrun condition on last buffer

2009-03-09 Thread Guennadi Liakhovetski
On Thu, 5 Mar 2009, Robert Jarzmik wrote: > The last buffer queued will often overrun, as the DMA chain > is finished, and the time the dma irq handler is activated, s/and the time/and during the time/ ? > the QIF fifos are filled by the sensor. > > The fix is to ignore the overrun condition on

[PATCH 4/4] pxa_camera: Fix overrun condition on last buffer

2009-03-05 Thread Robert Jarzmik
The last buffer queued will often overrun, as the DMA chain is finished, and the time the dma irq handler is activated, the QIF fifos are filled by the sensor. The fix is to ignore the overrun condition on the last queued buffer, and restart the capture only on intermediate buffers of the chain.