Re: [PATCH 35/68] [media] pwc-if: must check vb2_queue_init() success

2012-10-29 Thread Ezequiel Garcia
On Mon, Oct 29, 2012 at 8:44 AM, Mauro Carvalho Chehab wrote: > Em Mon, 29 Oct 2012 08:37:31 -0300 > Ezequiel Garcia escreveu: > >> On Sat, Oct 27, 2012 at 5:40 PM, Mauro Carvalho Chehab >> wrote: >> > drivers/media/usb/pwc/pwc-if.c: In function 'usb_pwc_probe': >> > drivers/media/usb/pwc/pwc-if

Re: [PATCH 35/68] [media] pwc-if: must check vb2_queue_init() success

2012-10-29 Thread Mauro Carvalho Chehab
Em Mon, 29 Oct 2012 08:37:31 -0300 Ezequiel Garcia escreveu: > On Sat, Oct 27, 2012 at 5:40 PM, Mauro Carvalho Chehab > wrote: > > drivers/media/usb/pwc/pwc-if.c: In function 'usb_pwc_probe': > > drivers/media/usb/pwc/pwc-if.c:1003:16: warning: ignoring return value of > > 'vb2_queue_init', dec

Re: [PATCH 35/68] [media] pwc-if: must check vb2_queue_init() success

2012-10-29 Thread Mauro Carvalho Chehab
Em Mon, 29 Oct 2012 08:37:31 -0300 Ezequiel Garcia escreveu: > On Sat, Oct 27, 2012 at 5:40 PM, Mauro Carvalho Chehab > wrote: > > drivers/media/usb/pwc/pwc-if.c: In function 'usb_pwc_probe': > > drivers/media/usb/pwc/pwc-if.c:1003:16: warning: ignoring return value of > > 'vb2_queue_init', dec

Re: [PATCH 35/68] [media] pwc-if: must check vb2_queue_init() success

2012-10-29 Thread Ezequiel Garcia
On Sat, Oct 27, 2012 at 5:40 PM, Mauro Carvalho Chehab wrote: > drivers/media/usb/pwc/pwc-if.c: In function 'usb_pwc_probe': > drivers/media/usb/pwc/pwc-if.c:1003:16: warning: ignoring return value of > 'vb2_queue_init', declared with attribute warn_unused_result [-Wunused-result] > In the past,

[PATCH 35/68] [media] pwc-if: must check vb2_queue_init() success

2012-10-27 Thread Mauro Carvalho Chehab
drivers/media/usb/pwc/pwc-if.c: In function 'usb_pwc_probe': drivers/media/usb/pwc/pwc-if.c:1003:16: warning: ignoring return value of 'vb2_queue_init', declared with attribute warn_unused_result [-Wunused-result] In the past, it used to have a logic there at queue init that would BUG() on errors.