Re: [PATCH 35/38] media: adv7180: add power pin control

2016-06-15 Thread Steve Longerbeam
Hi Lars, On 06/15/2016 09:05 AM, Lars-Peter Clausen wrote: > On 06/15/2016 12:49 AM, Steve Longerbeam wrote: >> +usleep_range(5000, 5001); > That's kind of not how usleep_range() (the emphasis is on range) is supposed > to be used. You typically dont care too much about the upper limit

Re: [PATCH 35/38] media: adv7180: add power pin control

2016-06-15 Thread Lars-Peter Clausen
On 06/15/2016 12:49 AM, Steve Longerbeam wrote: > + usleep_range(5000, 5001); That's kind of not how usleep_range() (the emphasis is on range) is supposed to be used. You typically dont care too much about the upper limit here so something like maybe 1 is more appropriate. > +sta

[PATCH 35/38] media: adv7180: add power pin control

2016-06-14 Thread Steve Longerbeam
Some targets control the ADV7180 power pin via a gpio, so add support for "pwdn-gpio" device node and pin control. Signed-off-by: Steve Longerbeam --- drivers/media/i2c/adv7180.c | 51 + 1 file changed, 51 insertions(+) diff --git a/drivers/media/i2c/