Re: [PATCH 3/8] drivers/media/video/hdpvr: introduce missing kfree

2010-02-03 Thread Mauro Carvalho Chehab
Janne Grunau wrote: > Hej, > > On Tue, Feb 02, 2010 at 01:19:15PM -0200, Mauro Carvalho Chehab wrote: >> Janne Grunau wrote: >>> On Fri, Sep 11, 2009 at 06:21:35PM +0200, Julia Lawall wrote: Error handling code following a kzalloc should free the allocated data. >>> Thanks for the report. I'

Re: [PATCH 3/8] drivers/media/video/hdpvr: introduce missing kfree

2010-02-03 Thread Janne Grunau
Hej, On Tue, Feb 02, 2010 at 01:19:15PM -0200, Mauro Carvalho Chehab wrote: > > Janne Grunau wrote: > > On Fri, Sep 11, 2009 at 06:21:35PM +0200, Julia Lawall wrote: > >> Error handling code following a kzalloc should free the allocated data. > > > > Thanks for the report. I'll commit a differe

Re: [PATCH 3/8] drivers/media/video/hdpvr: introduce missing kfree

2010-02-02 Thread Mauro Carvalho Chehab
Hi Janne, Janne Grunau wrote: > On Fri, Sep 11, 2009 at 06:21:35PM +0200, Julia Lawall wrote: >> Error handling code following a kzalloc should free the allocated data. > > Thanks for the report. I'll commit a different patch which adds the buffer > to the buffer list as soon it is allocated. The

Re: [PATCH 3/8] drivers/media/video/hdpvr: introduce missing kfree

2009-09-16 Thread Janne Grunau
On Fri, Sep 11, 2009 at 06:21:35PM +0200, Julia Lawall wrote: > > Error handling code following a kzalloc should free the allocated data. Thanks for the report. I'll commit a different patch which adds the buffer to the buffer list as soon it is allocated. The hdpvr_free_buffers() in the error ha

[PATCH 3/8] drivers/media/video/hdpvr: introduce missing kfree

2009-09-11 Thread Julia Lawall
From: Julia Lawall Error handling code following a kzalloc should free the allocated data. The semantic match that finds the problem is as follows: (http://www.emn.fr/x-info/coccinelle/) // @r exists@ local idexpression x; statement S; expression E; identifier f,f1,l; position p1,p2; expressio