bject: Re: [PATCH 3/6] [media] s5p-mfc: Core support for MFC v7
>
> On 18 June 2013 10:21, Arun Kumar K wrote:
> > Hi Kamil,
> >
> > Thank you for the review.
> >
> >
> >>> #define IS_MFCV6(dev)(dev->variant->version >=
> 0x60
Hi Sachin,
On Tue, Jun 18, 2013 at 11:42 AM, Sachin Kamat wrote:
> Hi Arun,
>
> On 18 June 2013 11:25, Arun Kumar K wrote:
>> Hi Sachin,
>>
>>
>> On Tue, Jun 18, 2013 at 10:56 AM, Sachin Kamat
>> wrote:
>>> On 18 June 2013 10:21, Arun Kumar K wrote:
Hi Kamil,
Thank you for the
Hi Arun,
On 18 June 2013 11:25, Arun Kumar K wrote:
> Hi Sachin,
>
>
> On Tue, Jun 18, 2013 at 10:56 AM, Sachin Kamat
> wrote:
>> On 18 June 2013 10:21, Arun Kumar K wrote:
>>> Hi Kamil,
>>>
>>> Thank you for the review.
>>>
>>>
> #define IS_MFCV6(dev)(dev->variant->versio
Hi Sachin,
On Tue, Jun 18, 2013 at 10:56 AM, Sachin Kamat wrote:
> On 18 June 2013 10:21, Arun Kumar K wrote:
>> Hi Kamil,
>>
>> Thank you for the review.
>>
>>
#define IS_MFCV6(dev)(dev->variant->version >= 0x60 ? 1 :
>>> 0)
+#define IS_MFCV7(dev)(dev
On 18 June 2013 10:21, Arun Kumar K wrote:
> Hi Kamil,
>
> Thank you for the review.
>
>
>>> #define IS_MFCV6(dev)(dev->variant->version >= 0x60 ? 1 :
>> 0)
>>> +#define IS_MFCV7(dev)(dev->variant->version >= 0x70 ? 1 :
>> 0)
>>
>> According to this, MFC v7 is also
Hi Kamil,
Thank you for the review.
>> #define IS_MFCV6(dev)(dev->variant->version >= 0x60 ? 1 :
> 0)
>> +#define IS_MFCV7(dev)(dev->variant->version >= 0x70 ? 1 :
> 0)
>
> According to this, MFC v7 is also detected as MFC v6. Was this intended?
Yes this was int
ailto:arun...@samsung.com]
> Sent: Monday, June 10, 2013 3:23 PM
> To: linux-media@vger.kernel.org
> Cc: k.deb...@samsung.com; jtp.p...@samsung.com; s.nawro...@samsung.com;
> avnd.ki...@samsung.com; arunkk.sams...@gmail.com
> Subject: [PATCH 3/6] [media] s5p-mfc: Core support for MFC v7
>
Adds variant data and core support for the MFC v7 firmware
Signed-off-by: Arun Kumar K
---
drivers/media/platform/s5p-mfc/s5p_mfc.c| 32 +++
drivers/media/platform/s5p-mfc/s5p_mfc_common.h |2 ++
2 files changed, 34 insertions(+)
diff --git a/drivers/media/plat