Re: [PATCH 3/4] videobuf2-dma-streaming: new videobuf2 memory allocator

2012-09-14 Thread Ezequiel Garcia
Hi Jon, On Thu, Sep 13, 2012 at 2:54 PM, Jonathan Corbet wrote: > > Well, there is some documentation here: > > https://lwn.net/Articles/447435/ > I thank you for this. It really helped me getting started on videobuf2. > This reminds me that I've always meant to turn it into something

Re: [PATCH 3/4] videobuf2-dma-streaming: new videobuf2 memory allocator

2012-09-13 Thread Federico Vaga
In data giovedì 13 settembre 2012 11:45:31, Jonathan Corbet ha scritto: > On Thu, 13 Sep 2012 17:46:32 +0200 > > Federico Vaga wrote: > > > A few words explaining why this memory handling module is required > > > or > > > beneficial will definitely improve the commit :) > > > > ok, I will write

Re: [PATCH 3/4] videobuf2-dma-streaming: new videobuf2 memory allocator

2012-09-13 Thread Federico Vaga
> Well, there is some documentation here: > > https://lwn.net/Articles/447435/ I know this, I learned from this page :) What I'm saying is that I don't know what to write inside the code to make it clearer than now. I think is clear, because if you know the videobuf2, you know what I'm d

Re: [PATCH 3/4] videobuf2-dma-streaming: new videobuf2 memory allocator

2012-09-13 Thread Jonathan Corbet
On Thu, 13 Sep 2012 17:42:33 +0200 Federico Vaga wrote: > > The header and esp. the source could really do with more > > documentation. It is not at all clear from the code what the > > dma-streaming allocator does and how it differs from other > > allocators. > > The other allocators are not

Re: [PATCH 3/4] videobuf2-dma-streaming: new videobuf2 memory allocator

2012-09-13 Thread Jonathan Corbet
On Thu, 13 Sep 2012 17:46:32 +0200 Federico Vaga wrote: > > A few words explaining why this memory handling module is required or > > beneficial will definitely improve the commit :) > > ok, I will write some lines In general, all of these patches need *much* better changelogs (i.e. they need

Re: [PATCH 3/4] videobuf2-dma-streaming: new videobuf2 memory allocator

2012-09-13 Thread Federico Vaga
> On Thursday, September 13, 2012 3:53 PM Federico Vaga wrote: > > Signed-off-by: Federico Vaga > > A few words explaining why this memory handling module is required or > beneficial will definitely improve the commit :) ok, I will write some lines > > +static void *vb2_dma_streaming_cookie(voi

Re: [PATCH 3/4] videobuf2-dma-streaming: new videobuf2 memory allocator

2012-09-13 Thread Federico Vaga
> typo: steaming -> streaming :-) fixed > The header and esp. the source could really do with more > documentation. It is not at all clear from the code what the > dma-streaming allocator does and how it differs from other > allocators. The other allocators are not documented and to understand t

Re: [PATCH 3/4] videobuf2-dma-streaming: new videobuf2 memory allocator

2012-09-13 Thread Hans Verkuil
On Thu 13 September 2012 15:52:47 Federico Vaga wrote: > Signed-off-by: Federico Vaga > --- > drivers/media/v4l2-core/Kconfig | 5 + > drivers/media/v4l2-core/Makefile | 1 + > drivers/media/v4l2-core/videobuf2-dma-streaming.c | 205 > ++

RE: [PATCH 3/4] videobuf2-dma-streaming: new videobuf2 memory allocator

2012-09-13 Thread Marek Szyprowski
Hello, On Thursday, September 13, 2012 3:53 PM Federico Vaga wrote: > Signed-off-by: Federico Vaga A few words explaining why this memory handling module is required or beneficial will definitely improve the commit :) > --- > drivers/media/v4l2-core/Kconfig | 5 + > drive

[PATCH 3/4] videobuf2-dma-streaming: new videobuf2 memory allocator

2012-09-13 Thread Federico Vaga
Signed-off-by: Federico Vaga --- drivers/media/v4l2-core/Kconfig | 5 + drivers/media/v4l2-core/Makefile | 1 + drivers/media/v4l2-core/videobuf2-dma-streaming.c | 205 ++ include/media/videobuf2-dma-streaming.h | 24 +++ 4 fil