Re: [PATCH 3/4] gsc-m2m: report correct format bytesperline and sizeimage

2014-04-08 Thread Shaik Ameer Basha
On Tue, Apr 8, 2014 at 12:26 PM, Shaik Ameer Basha wrote: > Hi John Sheu, > > Thanks for the patch. > Please find the review comments inline. > > On Wed, Mar 12, 2014 at 4:22 AM, John Sheu wrote: >> Explicitly specify sampling period for subsampled chroma formats, so >> stride and image size are

Re: [PATCH 3/4] gsc-m2m: report correct format bytesperline and sizeimage

2014-04-07 Thread Shaik Ameer Basha
Hi John Sheu, Thanks for the patch. Please find the review comments inline. On Wed, Mar 12, 2014 at 4:22 AM, John Sheu wrote: > Explicitly specify sampling period for subsampled chroma formats, so > stride and image size are properly reported through VIDIOC_{S,G}_FMT. > > Signed-off-by: John She

RE: [PATCH 3/4] gsc-m2m: report correct format bytesperline and sizeimage

2014-04-07 Thread Kamil Debski
John Sheu [mailto:s...@google.com] > Sent: Tuesday, March 11, 2014 11:52 PM > To: linux-media@vger.kernel.org > Cc: m.che...@samsung.com; k.deb...@samsung.com; posc...@google.com; > aru...@samsung.com; kgene@samsung.com; John Sheu > Subject: [PATCH 3/4] gsc-m2m: report correct format byt

[PATCH 3/4] gsc-m2m: report correct format bytesperline and sizeimage

2014-03-11 Thread John Sheu
Explicitly specify sampling period for subsampled chroma formats, so stride and image size are properly reported through VIDIOC_{S,G}_FMT. Signed-off-by: John Sheu --- drivers/media/platform/exynos-gsc/gsc-core.c | 154 +++ drivers/media/platform/exynos-gsc/gsc-core.h |