Re: [PATCH 3/4] [media] ddbridge: fix buffer overflow in max_set_input_unlocked()

2017-07-10 Thread Daniel Scheller
Am Mon, 10 Jul 2017 10:12:24 +0200 schrieb Ralph Metzler : > Daniel Scheller writes: > > From: Daniel Scheller > > > > Picked up code parts introduced one smatch error: > > > > drivers/media/pci/ddbridge/ddbridge-maxs8.c:163 > > max_set_input_unlocked() error: buffer overflow > > 'dev-

[PATCH 3/4] [media] ddbridge: fix buffer overflow in max_set_input_unlocked()

2017-07-10 Thread Ralph Metzler
Daniel Scheller writes: > From: Daniel Scheller > > Picked up code parts introduced one smatch error: > > drivers/media/pci/ddbridge/ddbridge-maxs8.c:163 max_set_input_unlocked() > error: buffer overflow 'dev->link[port->lnr].lnb.voltage' 4 <= 255 > > Fix this by clamping the .lnb.vo

[PATCH 3/4] [media] ddbridge: fix buffer overflow in max_set_input_unlocked()

2017-07-09 Thread Daniel Scheller
From: Daniel Scheller Picked up code parts introduced one smatch error: drivers/media/pci/ddbridge/ddbridge-maxs8.c:163 max_set_input_unlocked() error: buffer overflow 'dev->link[port->lnr].lnb.voltage' 4 <= 255 Fix this by clamping the .lnb.voltage array access to 0-3 by "& 3"'ing dvb->inpu