Re: [PATCH 3/3 v2] [media] sta2x11_vip: convert to videobuf2 and control framework

2012-08-06 Thread Federico Vaga
> > + vip->video_dev->flags |= V4L2_FL_USES_V4L2_FH | > > V4L2_FL_USE_FH_PRIO; > Been there, done that :-) > > V4L2_FL_USE_FH_PRIO is a bit number, not a bit mask. Use set_bit > instead: > > set_bit(V4L2_FL_USE_FH_PRIO, &vip->video_dev->flags); > > No need to set V4L2_FL_USES_V4L2_FH, BT

Re: [PATCH 3/3 v2] [media] sta2x11_vip: convert to videobuf2 and control framework

2012-08-06 Thread Hans Verkuil
On Mon August 6 2012 10:17:39 Federico Vaga wrote: > Signed-off-by: Federico Vaga > Acked-by: Giancarlo Asnaghi > > --- > drivers/media/video/sta2x11_vip.c | 1239 > + > 1 file modificato, 414 inserzioni(+), 825 rimozioni(-) > > diff --git a/drivers/media/v

[PATCH 3/3 v2] [media] sta2x11_vip: convert to videobuf2 and control framework

2012-08-06 Thread Federico Vaga
Signed-off-by: Federico Vaga Acked-by: Giancarlo Asnaghi --- drivers/media/video/sta2x11_vip.c | 1239 + 1 file modificato, 414 inserzioni(+), 825 rimozioni(-) diff --git a/drivers/media/video/sta2x11_vip.c b/drivers/media/video/sta2x11_vip.c index 4c10205.