Re: [PATCH 27/34] media: mx2_camera: use managed functions to clean up code

2012-09-18 Thread javier Martin
Hi Shawn, On 18 September 2012 09:43, Shawn Guo wrote: > On Mon, Sep 17, 2012 at 03:36:07PM +0200, javier Martin wrote: >> This patch breaks the driver: >> > Javier, > > Can you please apply the following change to see if it fixes the > problem? > > Shawn > > @@ -1783,6 +1783,8 @@ static int __de

Re: [PATCH 27/34] media: mx2_camera: use managed functions to clean up code

2012-09-18 Thread Shawn Guo
On Mon, Sep 17, 2012 at 03:36:07PM +0200, javier Martin wrote: > This patch breaks the driver: > Javier, Can you please apply the following change to see if it fixes the problem? Shawn @@ -1783,6 +1783,8 @@ static int __devinit mx2_camera_probe(struct platform_device *pdev)

Re: [PATCH 27/34] media: mx2_camera: use managed functions to clean up code

2012-09-17 Thread javier Martin
Hi, On 17 September 2012 11:11, Guennadi Liakhovetski wrote: > On Mon, 17 Sep 2012, Shawn Guo wrote: > >> Use managed functions to clean up the error handling code and function >> mx2_camera_remove(). Along with the change, a few variables get removed >> from struct mx2_camera_dev. >> >> Signed-

Re: [PATCH 27/34] media: mx2_camera: use managed functions to clean up code

2012-09-17 Thread Guennadi Liakhovetski
On Mon, 17 Sep 2012, Shawn Guo wrote: > Use managed functions to clean up the error handling code and function > mx2_camera_remove(). Along with the change, a few variables get removed > from struct mx2_camera_dev. > > Signed-off-by: Shawn Guo > Cc: Guennadi Liakhovetski > Cc: linux-media@vger

[PATCH 27/34] media: mx2_camera: use managed functions to clean up code

2012-09-16 Thread Shawn Guo
Use managed functions to clean up the error handling code and function mx2_camera_remove(). Along with the change, a few variables get removed from struct mx2_camera_dev. Signed-off-by: Shawn Guo Cc: Guennadi Liakhovetski Cc: linux-media@vger.kernel.org --- drivers/media/video/mx2_camera.c |