Re: [PATCH 2/8] media: v4l2-ioctl.h: convert debug into an enum of bits

2017-12-20 Thread Mauro Carvalho Chehab
Em Wed, 20 Dec 2017 12:47:23 +0200 Laurent Pinchart escreveu: > Hi Mauro, > > On Tuesday, 19 December 2017 17:34:46 EET Mauro Carvalho Chehab wrote: > > Em Tue, 19 Dec 2017 16:05:46 +0200 Laurent Pinchart escreveu: > > > On Tuesday, 19 December 2017 16:02:02 EET Laurent Pinchart wrote: > > >

Re: [PATCH 2/8] media: v4l2-ioctl.h: convert debug into an enum of bits

2017-12-20 Thread Laurent Pinchart
Hi Mauro, On Tuesday, 19 December 2017 17:34:46 EET Mauro Carvalho Chehab wrote: > Em Tue, 19 Dec 2017 16:05:46 +0200 Laurent Pinchart escreveu: > > On Tuesday, 19 December 2017 16:02:02 EET Laurent Pinchart wrote: > >> On Tuesday, 19 December 2017 13:39:27 EET Sakari Ailus wrote: > >>> On Mon, De

Re: [PATCH 2/8] media: v4l2-ioctl.h: convert debug into an enum of bits

2017-12-19 Thread Mauro Carvalho Chehab
Em Tue, 19 Dec 2017 19:17:12 +0200 Laurent Pinchart escreveu: > Hi Mauro, > > On Tuesday, 19 December 2017 17:37:58 EET Mauro Carvalho Chehab wrote: > > Em Tue, 19 Dec 2017 16:12:35 +0200 Sakari Ailus escreveu: > > > On Tue, Dec 19, 2017 at 04:02:02PM +0200, Laurent Pinchart wrote: > > >> An

Re: [PATCH 2/8] media: v4l2-ioctl.h: convert debug into an enum of bits

2017-12-19 Thread Laurent Pinchart
Hi Mauro, On Tuesday, 19 December 2017 17:37:58 EET Mauro Carvalho Chehab wrote: > Em Tue, 19 Dec 2017 16:12:35 +0200 Sakari Ailus escreveu: > > On Tue, Dec 19, 2017 at 04:02:02PM +0200, Laurent Pinchart wrote: > >> And furthermore using enum types in the uAPI is a bad idea as the enum > >> size i

Re: [PATCH 2/8] media: v4l2-ioctl.h: convert debug into an enum of bits

2017-12-19 Thread Mauro Carvalho Chehab
Em Tue, 19 Dec 2017 16:12:35 +0200 Sakari Ailus escreveu: > Hi Laurent, > > On Tue, Dec 19, 2017 at 04:02:02PM +0200, Laurent Pinchart wrote: > > And furthermore using enum types in the uAPI is a bad idea as the enum size > > is > > architecture-dependent. That's why we use integer types in st

Re: [PATCH 2/8] media: v4l2-ioctl.h: convert debug into an enum of bits

2017-12-19 Thread Mauro Carvalho Chehab
Em Tue, 19 Dec 2017 16:05:46 +0200 Laurent Pinchart escreveu: > On Tuesday, 19 December 2017 16:02:02 EET Laurent Pinchart wrote: > > On Tuesday, 19 December 2017 13:39:27 EET Sakari Ailus wrote: > > > Hi Mauro, > > > > > > On Mon, Dec 18, 2017 at 05:53:56PM -0200, Mauro Carvalho Chehab wrote:

Re: [PATCH 2/8] media: v4l2-ioctl.h: convert debug into an enum of bits

2017-12-19 Thread Sakari Ailus
Hi Laurent, On Tue, Dec 19, 2017 at 04:02:02PM +0200, Laurent Pinchart wrote: > And furthermore using enum types in the uAPI is a bad idea as the enum size > is > architecture-dependent. That's why we use integer types in structures used as > ioctl arguments. I guess we have an argeement on th

Re: [PATCH 2/8] media: v4l2-ioctl.h: convert debug into an enum of bits

2017-12-19 Thread Laurent Pinchart
On Tuesday, 19 December 2017 16:02:02 EET Laurent Pinchart wrote: > On Tuesday, 19 December 2017 13:39:27 EET Sakari Ailus wrote: > > Hi Mauro, > > > > On Mon, Dec 18, 2017 at 05:53:56PM -0200, Mauro Carvalho Chehab wrote: > > > The V4L2_DEV_DEBUG_IOCTL macros actually define a bitmask, > > > but

Re: [PATCH 2/8] media: v4l2-ioctl.h: convert debug into an enum of bits

2017-12-19 Thread Laurent Pinchart
On Tuesday, 19 December 2017 13:39:27 EET Sakari Ailus wrote: > Hi Mauro, > > On Mon, Dec 18, 2017 at 05:53:56PM -0200, Mauro Carvalho Chehab wrote: > > The V4L2_DEV_DEBUG_IOCTL macros actually define a bitmask, > > but without using Kernel's modern standards. Also, > > documentation looks akward.

Re: [PATCH 2/8] media: v4l2-ioctl.h: convert debug into an enum of bits

2017-12-19 Thread Sakari Ailus
Hi Mauro, On Mon, Dec 18, 2017 at 05:53:56PM -0200, Mauro Carvalho Chehab wrote: > The V4L2_DEV_DEBUG_IOCTL macros actually define a bitmask, > but without using Kernel's modern standards. Also, > documentation looks akward. > > So, convert them into an enum with valid bits, adding > the correspo

[PATCH 2/8] media: v4l2-ioctl.h: convert debug into an enum of bits

2017-12-18 Thread Mauro Carvalho Chehab
The V4L2_DEV_DEBUG_IOCTL macros actually define a bitmask, but without using Kernel's modern standards. Also, documentation looks akward. So, convert them into an enum with valid bits, adding the correspoinding kernel-doc documentation for it. In order to avoid possible conflicts, rename them fro