Re: [PATCH 2/5] media: v4l2-core changes to use media tuner token api

2014-10-06 Thread Laurent Pinchart
Hi Hans, On Wednesday 24 September 2014 14:25:59 Hans Verkuil wrote: > On 09/23/2014 10:46 PM, Shuah Khan wrote: > > Hi Devin/Mauro/Hans, > > > > Summarizing the discussion on v4l to keep others on this > > thread in the loop. Please see below: > > > > Hans! Could you please take a look and see

Re: [PATCH 2/5] media: v4l2-core changes to use media tuner token api

2014-09-25 Thread Hans Verkuil
On 09/24/2014 05:57 PM, Shuah Khan wrote: > On 09/24/2014 06:25 AM, Hans Verkuil wrote: >> Hi Shuah, >> >> >> Let's be realistic: if an application doesn't test for error codes, >> then that's the problem of the application. Also, EBUSY will only be >> returned if someone else is holding the tuner

Re: [PATCH 2/5] media: v4l2-core changes to use media tuner token api

2014-09-24 Thread Shuah Khan
On 09/24/2014 06:25 AM, Hans Verkuil wrote: > Hi Shuah, > > > Let's be realistic: if an application doesn't test for error codes, > then that's the problem of the application. Also, EBUSY will only be > returned if someone else is holding the tuner in a different mode. > And that didn't work anyw

Re: [PATCH 2/5] media: v4l2-core changes to use media tuner token api

2014-09-24 Thread Shuah Khan
On 09/24/2014 05:57 AM, Hans Verkuil wrote: > Hi Shuah, > > Here is my review... > > On 09/22/2014 05:00 PM, Shuah Khan wrote: >> Changes to v4l2-core to hold tuner token in v4l2 ioctl that change >> the tuner modes, and reset the token from fh exit. The changes are >> limited to vb2 calls that d

Re: [PATCH 2/5] media: v4l2-core changes to use media tuner token api

2014-09-24 Thread Shuah Khan
On 09/24/2014 05:57 AM, Hans Verkuil wrote: > Hi Shuah, > > Here is my review... > > On 09/22/2014 05:00 PM, Shuah Khan wrote: >> Changes to v4l2-core to hold tuner token in v4l2 ioctl that change >> the tuner modes, and reset the token from fh exit. The changes are >> limited to vb2 calls that d

Re: [PATCH 2/5] media: v4l2-core changes to use media tuner token api

2014-09-24 Thread Hans Verkuil
Hi Shuah, On 09/23/2014 10:46 PM, Shuah Khan wrote: Hi Devin/Mauro/Hans, Summarizing the discussion on v4l to keep others on this thread in the loop. Please see below: Hans! Could you please take a look and see if it raises any red flags for you. On 09/23/2014 08:17 AM, Devin Heitmueller wrot

Re: [PATCH 2/5] media: v4l2-core changes to use media tuner token api

2014-09-24 Thread Hans Verkuil
Hi Shuah, Here is my review... On 09/22/2014 05:00 PM, Shuah Khan wrote: Changes to v4l2-core to hold tuner token in v4l2 ioctl that change the tuner modes, and reset the token from fh exit. The changes are limited to vb2 calls that disrupt digital stream. vb1 changes are made in the driver. Th

Re: [PATCH 2/5] media: v4l2-core changes to use media tuner token api

2014-09-23 Thread Shuah Khan
Hi Devin/Mauro/Hans, Summarizing the discussion on v4l to keep others on this thread in the loop. Please see below: Hans! Could you please take a look and see if it raises any red flags for you. On 09/23/2014 08:17 AM, Devin Heitmueller wrote: > > We can always start with coarse locking on ope

Re: [PATCH 2/5] media: v4l2-core changes to use media tuner token api

2014-09-23 Thread Devin Heitmueller
Hello Shuah, >> What about G_INPUT and G_TUNER? Consider the following use case, which is >> entirely legal in the V4L2 API: > > Did you mean G_INPUT and G_STD here? I didn't see G_TUNER mentioned > below in the use-case. It can be either ENUM_INPUT or G_TUNER. Both return status information th

Re: [PATCH 2/5] media: v4l2-core changes to use media tuner token api

2014-09-22 Thread Shuah Khan
Hi Devin, On 09/22/2014 01:21 PM, Devin Heitmueller wrote: > Hi Shuah, > > What about G_INPUT and G_TUNER? Consider the following use case, which is > entirely legal in the V4L2 API: Did you mean G_INPUT and G_STD here? I didn't see G_TUNER mentioned below in the use-case. I didn't know this u

[PATCH 2/5] media: v4l2-core changes to use media tuner token api

2014-09-22 Thread Shuah Khan
Changes to v4l2-core to hold tuner token in v4l2 ioctl that change the tuner modes, and reset the token from fh exit. The changes are limited to vb2 calls that disrupt digital stream. vb1 changes are made in the driver. The following ioctls are changed: S_INPUT, S_OUTPUT, S_FMT, S_TUNER, S_MODULAT