Hi Laurent,
Thanks for your review.
On 2016-09-05 18:43:58 +0300, Laurent Pinchart wrote:
> Hi Niklas,
>
> Thank you for the patch.
>
> On Friday 02 Sep 2016 15:47:14 Niklas Söderlund wrote:
> > The HGT is a Histogram Generator Two-Dimensions. It computes a weighted
> > frequency histograms for
On Monday 05 Sep 2016 17:57:11 Geert Uytterhoeven wrote:
> On Mon, Sep 5, 2016 at 5:43 PM, Laurent Pinchart wrote:
> >> + for (n = 0; n < 6; n++)
> >
> > Nitpicking, the driver uses pre-increment in for loops (++n), not post-
> > increment. This used to be a best-practice rule in C++, where
>
Hi Laurent,
On Mon, Sep 5, 2016 at 5:43 PM, Laurent Pinchart
wrote:
>> + for (n = 0; n < 6; n++)
>
> Nitpicking, the driver uses pre-increment in for loops (++n), not post-
> increment. This used to be a best-practice rule in C++, where pre-increment
> can be faster for non-native types (see
Hi Niklas,
Thank you for the patch.
On Friday 02 Sep 2016 15:47:14 Niklas Söderlund wrote:
> The HGT is a Histogram Generator Two-Dimensions. It computes a weighted
> frequency histograms for hue and saturation areas over a configurable
> region of the image with optional subsampling.
>
> Signed
The HGT is a Histogram Generator Two-Dimensions. It computes a weighted
frequency histograms for hue and saturation areas over a configurable
region of the image with optional subsampling.
Signed-off-by: Niklas Söderlund
---
drivers/media/platform/vsp1/Makefile | 2 +-
drivers/media/platf
