Re: [PATCH 2/2] media: omap3isp change to devm for resources

2016-12-16 Thread Hans Verkuil
On 16/12/16 13:19, Laurent Pinchart wrote: Hi Hans, On Friday 16 Dec 2016 12:39:49 Hans Verkuil wrote: On 15/12/16 20:40, Shuah Khan wrote: Using devm resources that have external dependencies such as a dev for a file handler could result in devm resources getting released durin unbind while a

Re: [PATCH 2/2] media: omap3isp change to devm for resources

2016-12-16 Thread Laurent Pinchart
Hi Hans, On Friday 16 Dec 2016 12:39:49 Hans Verkuil wrote: > On 15/12/16 20:40, Shuah Khan wrote: > > Using devm resources that have external dependencies such as a dev > > for a file handler could result in devm resources getting released > > durin unbind while an application has the file open h

Re: [PATCH 2/2] media: omap3isp change to devm for resources

2016-12-16 Thread Hans Verkuil
On 15/12/16 20:40, Shuah Khan wrote: Using devm resources that have external dependencies such as a dev for a file handler could result in devm resources getting released durin unbind while an application has the file open holding pointer to the devm resource. This results in use-after-free error

Re: [PATCH 2/2] media: omap3isp change to devm for resources

2016-12-16 Thread kbuild test robot
Hi Shuah, [auto build test WARNING on v4.9-rc8] [cannot apply to linuxtv-media/master next-20161215] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Shuah-Khan/omap3-devm-usage-removal/20161216-1

Re: [PATCH 2/2] media: omap3isp change to devm for resources

2016-12-15 Thread Laurent Pinchart
Hi Shuah, On Thursday 15 Dec 2016 15:51:41 Shuah Khan wrote: > On 12/15/2016 03:33 PM, Laurent Pinchart wrote: > > Hi Shuah, > > > > Thank you for the patch. > > > > Sakari has submitted a similar patch as part of his kref series. Please > > use it as a base point and rework it if you want to ge

Re: [PATCH 2/2] media: omap3isp change to devm for resources

2016-12-15 Thread Shuah Khan
On 12/15/2016 03:33 PM, Laurent Pinchart wrote: > Hi Shuah, > > Thank you for the patch. > > Sakari has submitted a similar patch as part of his kref series. Please use > it > as a base point and rework it if you want to get it merged separately. I've > reviewed the patch and left quite a few

Re: [PATCH 2/2] media: omap3isp change to devm for resources

2016-12-15 Thread Laurent Pinchart
Hi Shuah, Thank you for the patch. Sakari has submitted a similar patch as part of his kref series. Please use it as a base point and rework it if you want to get it merged separately. I've reviewed the patch and left quite a few comments that need to be addressed. On Thursday 15 Dec 2016 12:4

[PATCH 2/2] media: omap3isp change to devm for resources

2016-12-15 Thread Shuah Khan
Using devm resources that have external dependencies such as a dev for a file handler could result in devm resources getting released durin unbind while an application has the file open holding pointer to the devm resource. This results in use-after-free errors when the application exits. Signed-o