Re: [PATCH 2/2] drivers/media/dvb/dvb-usb/dib0700: CodingStyle fixes

2010-05-24 Thread David Ellingsworth
See comments below: On Mon, May 24, 2010 at 6:57 AM, Daniel Mack wrote: > @@ -106,28 +106,29 @@ int dib0700_ctrl_rd(struct dvb_usb_device *d, u8 *tx, > u8 txlen, u8 *rx, u8 rxlen >  int dib0700_set_gpio(struct dvb_usb_device *d, enum dib07x0_gpios gpio, u8 > gpio_dir, u8 gpio_val) >  { >    

Re: [PATCH 2/2] drivers/media/dvb/dvb-usb/dib0700: CodingStyle fixes

2010-05-24 Thread Wolfram Sang
On Mon, May 24, 2010 at 12:57:15PM +0200, Daniel Mack wrote: > Signed-off-by: Daniel Mack > Cc: Wolfram Sang > Cc: Mauro Carvalho Chehab > Cc: Jiri Slaby > Cc: Dmitry Torokhov > Cc: Devin Heitmueller > Cc: linux-media@vger.kernel.org Looks correct to me and definately more readable: Acked-b

[PATCH 2/2] drivers/media/dvb/dvb-usb/dib0700: CodingStyle fixes

2010-05-24 Thread Daniel Mack
Signed-off-by: Daniel Mack Cc: Wolfram Sang Cc: Mauro Carvalho Chehab Cc: Jiri Slaby Cc: Dmitry Torokhov Cc: Devin Heitmueller Cc: linux-media@vger.kernel.org --- drivers/media/dvb/dvb-usb/dib0700_core.c | 66 -- 1 files changed, 35 insertions(+), 31 deletions(-