Re: [PATCH 2/2] [media] media-device: use unsigned ints on some places

2015-11-23 Thread Laurent Pinchart
Hi Mauro, Thank you for the patch. On Wednesday 09 September 2015 08:32:03 Mauro Carvalho Chehab wrote: > The entity->num_pads are defined as u16. So, better to use an > unsigned int, as this prevents additional warnings when W=2 > (or W=1 on some architectures). > > The "i" counter at __media_d

Re: [PATCH 2/2] [media] media-device: use unsigned ints on some places

2015-09-09 Thread Hans Verkuil
On 09/09/15 13:32, Mauro Carvalho Chehab wrote: > The entity->num_pads are defined as u16. So, better to use an > unsigned int, as this prevents additional warnings when W=2 > (or W=1 on some architectures). > > The "i" counter at __media_device_get_topology() is also a > monotonic counter that sh

[PATCH 2/2] [media] media-device: use unsigned ints on some places

2015-09-09 Thread Mauro Carvalho Chehab
The entity->num_pads are defined as u16. So, better to use an unsigned int, as this prevents additional warnings when W=2 (or W=1 on some architectures). The "i" counter at __media_device_get_topology() is also a monotonic counter that should never be below zero. So, make it unsigned too. Suggest