Re: [PATCH 2/2] [media] media-device: split media initialization and registration

2015-12-28 Thread Mauro Carvalho Chehab
Em Mon, 28 Dec 2015 08:26:33 -0200 Mauro Carvalho Chehab escreveu: > Em Mon, 28 Dec 2015 03:14:53 +0200 > Sakari Ailus escreveu: > > > Hi Mauro, > > > > On Tue, Dec 15, 2015 at 09:13:42AM -0200, Mauro Carvalho Chehab wrote: > > > Em Thu, 10 Sep 2015 20:14:04 +0300 > > > Sakari Ailus escreveu:

Re: [PATCH 2/2] [media] media-device: split media initialization and registration

2015-12-28 Thread Mauro Carvalho Chehab
Em Mon, 28 Dec 2015 03:14:53 +0200 Sakari Ailus escreveu: > Hi Mauro, > > On Tue, Dec 15, 2015 at 09:13:42AM -0200, Mauro Carvalho Chehab wrote: > > Em Thu, 10 Sep 2015 20:14:04 +0300 > > Sakari Ailus escreveu: > > > > > Hi Javier, > > > > > > Thanks for the set! A few comments below. > > >

Re: [PATCH 2/2] [media] media-device: split media initialization and registration

2015-12-27 Thread Sakari Ailus
Hi Mauro, On Tue, Dec 15, 2015 at 09:13:42AM -0200, Mauro Carvalho Chehab wrote: > Em Thu, 10 Sep 2015 20:14:04 +0300 > Sakari Ailus escreveu: > > > Hi Javier, > > > > Thanks for the set! A few comments below. > > > > Javier Martinez Canillas wrote: > > > The media device node is registered an

Re: [PATCH 2/2] [media] media-device: split media initialization and registration

2015-12-21 Thread Javier Martinez Canillas
Hello Mauro, On 12/15/2015 08:13 AM, Mauro Carvalho Chehab wrote: [snip] >>> >>> /** >>> - * media_device_register - register a media device >>> + * media_device_init() - initialize a media device >>> * @mdev: The media device >>> * >>> * The caller is responsible for initializing the

Re: [PATCH 2/2] [media] media-device: split media initialization and registration

2015-12-15 Thread Mauro Carvalho Chehab
Em Thu, 10 Sep 2015 20:14:04 +0300 Sakari Ailus escreveu: > Hi Javier, > > Thanks for the set! A few comments below. > > Javier Martinez Canillas wrote: > > The media device node is registered and so made visible to user-space > > before entities are registered and links created which means tha

Re: [PATCH 2/2] [media] media-device: split media initialization and registration

2015-09-11 Thread Sakari Ailus
Hi Mauro, Mauro Carvalho Chehab wrote: > Em Fri, 11 Sep 2015 09:31:36 +0200 > Javier Martinez Canillas escreveu: > >> Hello Sakari, >> >> On 09/11/2015 07:51 AM, Sakari Ailus wrote: >>> Hi Javier, >>> >>> Javier Martinez Canillas wrote: Hello Sakari, On 09/10/2015 07:14 PM, Sakari

Re: [PATCH 2/2] [media] media-device: split media initialization and registration

2015-09-11 Thread Mauro Carvalho Chehab
Em Fri, 11 Sep 2015 09:31:36 +0200 Javier Martinez Canillas escreveu: > Hello Sakari, > > On 09/11/2015 07:51 AM, Sakari Ailus wrote: > > Hi Javier, > > > > Javier Martinez Canillas wrote: > >> Hello Sakari, > >> > >> On 09/10/2015 07:14 PM, Sakari Ailus wrote: > >>> Hi Javier, > >>> > >>> Than

Re: [PATCH 2/2] [media] media-device: split media initialization and registration

2015-09-11 Thread Javier Martinez Canillas
Hello Sakari, On 09/11/2015 07:51 AM, Sakari Ailus wrote: > Hi Javier, > > Javier Martinez Canillas wrote: >> Hello Sakari, >> >> On 09/10/2015 07:14 PM, Sakari Ailus wrote: >>> Hi Javier, >>> >>> Thanks for the set! A few comments below. >>> >> >> Thanks to you for your feedback. >> >>> Javier M

Re: [PATCH 2/2] [media] media-device: split media initialization and registration

2015-09-10 Thread Sakari Ailus
Hi Javier, Javier Martinez Canillas wrote: Hello Sakari, On 09/10/2015 07:14 PM, Sakari Ailus wrote: Hi Javier, Thanks for the set! A few comments below. Thanks to you for your feedback. Javier Martinez Canillas wrote: The media device node is registered and so made visible to user-spac

Re: [PATCH 2/2] [media] media-device: split media initialization and registration

2015-09-10 Thread Javier Martinez Canillas
Hello Sakari, On 09/10/2015 07:39 PM, Sakari Ailus wrote: > Javier Martinez Canillas wrote: >> Also, add a media_entity_cleanup() function that will destroy the >> graph_mutex that is initialized in media_entity_init(). > > media_device_init() and media_device_cleanup()? > Right, sorry about tha

Re: [PATCH 2/2] [media] media-device: split media initialization and registration

2015-09-10 Thread Javier Martinez Canillas
Hello Sakari, On 09/10/2015 07:14 PM, Sakari Ailus wrote: > Hi Javier, > > Thanks for the set! A few comments below. > Thanks to you for your feedback. > Javier Martinez Canillas wrote: >> The media device node is registered and so made visible to user-space >> before entities are registered an

Re: [PATCH 2/2] [media] media-device: split media initialization and registration

2015-09-10 Thread Sakari Ailus
Javier Martinez Canillas wrote: > Also, add a media_entity_cleanup() function that will destroy the > graph_mutex that is initialized in media_entity_init(). media_device_init() and media_device_cleanup()? -- Sakari Ailus sakari.ai...@linux.intel.com -- To unsubscribe from this list: send the li

Re: [PATCH 2/2] [media] media-device: split media initialization and registration

2015-09-10 Thread Sakari Ailus
Hi Javier, Thanks for the set! A few comments below. Javier Martinez Canillas wrote: > The media device node is registered and so made visible to user-space > before entities are registered and links created which means that the > media graph obtained by user-space could be only partially enumera

[PATCH 2/2] [media] media-device: split media initialization and registration

2015-09-10 Thread Javier Martinez Canillas
The media device node is registered and so made visible to user-space before entities are registered and links created which means that the media graph obtained by user-space could be only partially enumerated if that happens too early before all the graph has been created. To avoid this race cond