Re: [PATCH 1/8]reiserfs:stree.c Fix variable set but not used.

2010-06-14 Thread Justin P. Mattock
On 06/14/2010 04:07 PM, Stefan Richter wrote: On 14 Jun, Justin P. Mattock wrote: On 06/14/2010 02:47 PM, Edward Shishkin wrote: Whitespaces should be removed. I recommend quilt package for managing patches: "quilt refresh --strip-trailing-whitespace" is your friend.. o.k. I resent this.. fix

Re: [PATCH 1/8]reiserfs:stree.c Fix variable set but not used.

2010-06-14 Thread Stefan Richter
On 14 Jun, Justin P. Mattock wrote: > On 06/14/2010 02:47 PM, Edward Shishkin wrote: >> Whitespaces should be removed. >> I recommend quilt package for managing patches: >> "quilt refresh --strip-trailing-whitespace" is your friend.. > > o.k. I resent this.. fixed the whitespace(hopefully) > and a

Re: [PATCH 1/8]reiserfs:stree.c Fix variable set but not used.

2010-06-14 Thread Justin P. Mattock
On 06/14/2010 02:47 PM, Edward Shishkin wrote: Justin P. Mattock wrote: On 06/14/2010 02:05 PM, Edward Shishkin wrote: Justin P. Mattock wrote: Not sure if this is correct or not. the below patch gets rid of this warning message produced by gcc 4.6.0 fs/reiserfs/stree.c: In function 'search_b

Re: [PATCH 1/8]reiserfs:stree.c Fix variable set but not used.

2010-06-14 Thread Edward Shishkin
Justin P. Mattock wrote: On 06/14/2010 02:05 PM, Edward Shishkin wrote: Justin P. Mattock wrote: Not sure if this is correct or not. the below patch gets rid of this warning message produced by gcc 4.6.0 fs/reiserfs/stree.c: In function 'search_by_key': fs/reiserfs/stree.c:602:6: warning: vari

Re: [PATCH 1/8]reiserfs:stree.c Fix variable set but not used.

2010-06-14 Thread Justin P. Mattock
On 06/14/2010 02:05 PM, Edward Shishkin wrote: Justin P. Mattock wrote: Not sure if this is correct or not. the below patch gets rid of this warning message produced by gcc 4.6.0 fs/reiserfs/stree.c: In function 'search_by_key': fs/reiserfs/stree.c:602:6: warning: variable 'right_neighbor_of_le

Re: [PATCH 1/8]reiserfs:stree.c Fix variable set but not used.

2010-06-14 Thread Justin P. Mattock
On 06/14/2010 01:48 PM, Nick Bowler wrote: On 13:26 Mon 14 Jun , Justin P. Mattock wrote: @@ -617,8 +616,7 @@ int search_by_key(struct super_block *sb, const struct cpu_key *key,/* Key to s pathrelse(search_path); - right_neighbor_of_leaf_node = 0; - + This

Re: [PATCH 1/8]reiserfs:stree.c Fix variable set but not used.

2010-06-14 Thread Edward Shishkin
Justin P. Mattock wrote: Not sure if this is correct or not. the below patch gets rid of this warning message produced by gcc 4.6.0 fs/reiserfs/stree.c: In function 'search_by_key': fs/reiserfs/stree.c:602:6: warning: variable 'right_neighbor_of_leaf_node' set but not used Signed-off-by: Just

Re: [PATCH 1/8]reiserfs:stree.c Fix variable set but not used.

2010-06-14 Thread Nick Bowler
On 13:26 Mon 14 Jun , Justin P. Mattock wrote: > @@ -617,8 +616,7 @@ int search_by_key(struct super_block *sb, const struct > cpu_key *key, /* Key to s > > pathrelse(search_path); > > - right_neighbor_of_leaf_node = 0; > - > + This hunk introduces whitespace on the emp

[PATCH 1/8]reiserfs:stree.c Fix variable set but not used.

2010-06-14 Thread Justin P. Mattock
Not sure if this is correct or not. the below patch gets rid of this warning message produced by gcc 4.6.0 fs/reiserfs/stree.c: In function 'search_by_key': fs/reiserfs/stree.c:602:6: warning: variable 'right_neighbor_of_leaf_node' set but not used Signed-off-by: Justin P. Mattock --- fs/rei