Re: [PATCH 1/8] [media] em28xx: fix em28xx-input removal

2014-12-21 Thread Frank Schäfer
Am 20.12.2014 um 15:51 schrieb Russell King - ARM Linux: > On Sat, Dec 20, 2014 at 03:11:54PM +0100, Frank Schäfer wrote: >> Hi Russel, > I guess you won't mind if I mis-spell your name too... Wow... it seems to be very easy to offend you... Sorry, that was definitely not my intention. I did not

Re: [PATCH 1/8] [media] em28xx: fix em28xx-input removal

2014-12-20 Thread Russell King - ARM Linux
On Sat, Dec 20, 2014 at 03:11:54PM +0100, Frank Schäfer wrote: > Hi Russel, I guess you won't mind if I mis-spell your name too... > I'd prefer to keep the button initialization related stuff together in > em28xx_init_buttons() and do the cancel_delayed_work_sync() only if we > have buttons (dev-

[PATCH 1/8] [media] em28xx: fix em28xx-input removal

2014-12-20 Thread Russell King
Removing the em28xx-rc module results in the following lockdep splat, which is caused by trying to call cancel_delayed_work_sync() on an uninitialised delayed work. Fix this by ensuring we always initialise the work. INFO: trying to register non-static key. the code is fine but needs lockdep anno