Re: [PATCH 1/5] mt9m111: set inital return values to zero

2011-07-17 Thread Guennadi Liakhovetski
On Thu, 14 Jul 2011, Laurent Pinchart wrote: > Hi Michael, > > There's no need to set initial return values to zero if they're assigned to > in > all code paths. > > [snip] > > > *client) static int mt9m111_enable(struct i2c_client *client) > > { > > struct mt9m111 *mt9m111 = to_mt9m111(

Re: [PATCH 1/5] mt9m111: set inital return values to zero

2011-07-14 Thread Laurent Pinchart
Hi Michael, There's no need to set initial return values to zero if they're assigned to in all code paths. [snip] > *client) static int mt9m111_enable(struct i2c_client *client) > { > struct mt9m111 *mt9m111 = to_mt9m111(client); > - int ret; > + int ret = 0; > > ret = reg

[PATCH 1/5] mt9m111: set inital return values to zero

2011-07-12 Thread Michael Grzeschik
Signed-off-by: Michael Grzeschik --- drivers/media/video/mt9m111.c | 32 1 files changed, 16 insertions(+), 16 deletions(-) diff --git a/drivers/media/video/mt9m111.c b/drivers/media/video/mt9m111.c index ebebed9..f10dcf0 100644 --- a/drivers/media/video/mt9m11