Re: [PATCH 1/5] media: adv748x: Rework reset procedure

2018-12-13 Thread Laurent Pinchart
Hi Jacopo, Thank you for the patch. On Wednesday, 12 December 2018 12:13:44 EET Kieran Bingham wrote: > On 12/12/2018 08:16, jacopo mondi wrote: > > On Tue, Dec 11, 2018 at 11:52:03PM +, Kieran Bingham wrote: > >> On 11/12/2018 15:16, Jacopo Mondi wrote: > >>> Re-work the chip reset procedure

Re: [PATCH 1/5] media: adv748x: Rework reset procedure

2018-12-12 Thread Kieran Bingham
Heya On 12/12/2018 08:16, jacopo mondi wrote: > Hi Kieran, >thanks for review > > On Tue, Dec 11, 2018 at 11:52:03PM +, Kieran Bingham wrote: >> Hi Jacopo, >> >> On 11/12/2018 15:16, Jacopo Mondi wrote: >>> Re-work the chip reset procedure to configure the CP (HDMI) and SD (AFE) >>> core

Re: [PATCH 1/5] media: adv748x: Rework reset procedure

2018-12-12 Thread jacopo mondi
Hi Kieran, thanks for review On Tue, Dec 11, 2018 at 11:52:03PM +, Kieran Bingham wrote: > Hi Jacopo, > > On 11/12/2018 15:16, Jacopo Mondi wrote: > > Re-work the chip reset procedure to configure the CP (HDMI) and SD (AFE) > > cores > > before resetting the MIPI CSI-2 TXs. > > > > Signed-

Re: [PATCH 1/5] media: adv748x: Rework reset procedure

2018-12-11 Thread Kieran Bingham
Hi Jacopo, On 11/12/2018 15:16, Jacopo Mondi wrote: > Re-work the chip reset procedure to configure the CP (HDMI) and SD (AFE) cores > before resetting the MIPI CSI-2 TXs. > > Signed-off-by: Jacopo Mondi > --- > drivers/media/i2c/adv748x/adv748x-core.c | 24 ++-- > 1 file ch

[PATCH 1/5] media: adv748x: Rework reset procedure

2018-12-11 Thread Jacopo Mondi
Re-work the chip reset procedure to configure the CP (HDMI) and SD (AFE) cores before resetting the MIPI CSI-2 TXs. Signed-off-by: Jacopo Mondi --- drivers/media/i2c/adv748x/adv748x-core.c | 24 ++-- 1 file changed, 10 insertions(+), 14 deletions(-) diff --git a/drivers/medi