Re: [PATCH 1/5] CSI camera interface driver for MX1

2009-03-27 Thread Mauro Carvalho Chehab
On Fri, 27 Mar 2009 15:39:59 +0200 Darius Augulis wrote: > Mauro Carvalho Chehab wrote: > > On Fri, 27 Mar 2009 11:37:23 +0200 > > Darius Augulis wrote: > > > >> Mauro Carvalho Chehab wrote: > >>> Hi Darius, > >>> > >>> Please always base your patches against the last v4l-dvb tree or > l

Re: [PATCH 1/5] CSI camera interface driver for MX1

2009-03-27 Thread Guennadi Liakhovetski
On Fri, 27 Mar 2009, Russell King - ARM Linux wrote: > On Fri, Mar 27, 2009 at 05:18:18PM +0200, Darius Augulis wrote: > > > You use an FIQ for SoF, and spin_lock_irqsave() to protect. Don't they > > > only disable IRQs and not FIQs? But it seems your FIQ cannot cause any > > > trouble, so, it s

Re: [PATCH 1/5] CSI camera interface driver for MX1

2009-03-27 Thread Russell King - ARM Linux
On Fri, Mar 27, 2009 at 05:18:18PM +0200, Darius Augulis wrote: > > You use an FIQ for SoF, and spin_lock_irqsave() to protect. Don't they > > only disable IRQs and not FIQs? But it seems your FIQ cannot cause any > > trouble, so, it should be fine. Do you really need an FIQ? This is precisely t

Re: [PATCH 1/5] CSI camera interface driver for MX1

2009-03-27 Thread Darius Augulis
Hi Guennadi, +/* + * Videobuf operations + */ +static int imx_videobuf_setup(struct videobuf_queue *vq, unsigned int *count, + unsigned int *size) +{ + struct soc_camera_device *icd = vq->priv_data; + + *size = icd->width * icd->height * + (

Re: [PATCH 1/5] CSI camera interface driver for MX1

2009-03-27 Thread Darius Augulis
Mauro Carvalho Chehab wrote: > On Fri, 27 Mar 2009 11:37:23 +0200 > Darius Augulis wrote: > >> Mauro Carvalho Chehab wrote: >>> Hi Darius, >>> >>> Please always base your patches against the last v4l-dvb tree or linux-next. >>> This is specially important those days, where v4l core is suffering s

Re: [PATCH 1/5] CSI camera interface driver for MX1

2009-03-27 Thread Mauro Carvalho Chehab
27 Mar 2009 10:34:51 + Sender: linux-arm-kernel-boun...@lists.arm.linux.org.uk Your mail to 'Linux-arm-kernel' with the subject Re: [PATCH 1/5] CSI camera interface driver for MX1 Is being held until the list moderator can review it for approval. The reason it is being held:

Re: [PATCH 1/5] CSI camera interface driver for MX1

2009-03-27 Thread Mauro Carvalho Chehab
On Fri, 27 Mar 2009 11:37:23 +0200 Darius Augulis wrote: > Mauro Carvalho Chehab wrote: > > Hi Darius, > > > > Please always base your patches against the last v4l-dvb tree or linux-next. > > This is specially important those days, where v4l core is suffering several > > changes. > > Hi, > > c

Re: [PATCH 1/5] CSI camera interface driver for MX1

2009-03-27 Thread Darius Augulis
Mauro Carvalho Chehab wrote: Hi Darius, Please always base your patches against the last v4l-dvb tree or linux-next. This is specially important those days, where v4l core is suffering several changes. Hi, could you please advice which v4l-dvb Git repository I should pull from? Because git://

Re: [PATCH 1/5] CSI camera interface driver for MX1

2009-03-27 Thread Russell King - ARM Linux
On Fri, Mar 27, 2009 at 08:33:27AM +0100, Holger Schurig wrote: > > Sparse is another tool which can be used while building the > > kernel to increase the build time checking, but it can be > > quite noisy, so please only look at stuff which pops up for > > your specific area. > > To get rid of so

Re: [PATCH 1/5] CSI camera interface driver for MX1

2009-03-27 Thread Holger Schurig
> Sparse is another tool which can be used while building the > kernel to increase the build time checking, but it can be > quite noisy, so please only look at stuff which pops up for > your specific area. To get rid of some of the warnings, you can analyze only the parts of the source that you'r

Re: [PATCH 1/5] CSI camera interface driver for MX1

2009-03-26 Thread Dave Strauss
Guennadi Liakhovetski wrote: On Thu, 26 Mar 2009, Mauro Carvalho Chehab wrote: + /* common v4l buffer stuff -- must be first */ + struct videobuf_buffer vb; Here you have one space + + const struct soc_camera_data_format*fmt; Here you have 8 spaces

Re: [PATCH 1/5] CSI camera interface driver for MX1

2009-03-26 Thread Russell King - ARM Linux
On Thu, Mar 26, 2009 at 05:31:35PM -0400, Dave Strauss wrote: > Newbie question -- where does one find checkpatch.pl? And are there any other > tools we should be running on patches before we submit them? scripts/checkpatch.pl in the kernel source. Sparse is another tool which can be used while

Re: [PATCH 1/5] CSI camera interface driver for MX1

2009-03-26 Thread Mauro Carvalho Chehab
On Thu, 26 Mar 2009 17:31:35 -0400 Dave Strauss wrote: > Guennadi Liakhovetski wrote: > > On Thu, 26 Mar 2009, Mauro Carvalho Chehab wrote: > > > > + /* common v4l buffer stuff -- must be first */ > > + struct videobuf_buffer vb; > > > Here you have one space >

Re: [PATCH 1/5] CSI camera interface driver for MX1

2009-03-26 Thread Guennadi Liakhovetski
On Thu, 26 Mar 2009, Mauro Carvalho Chehab wrote: > > >> +/* common v4l buffer stuff -- must be first */ > > >> +struct videobuf_buffer vb; > > >> > > > > > > Here you have one space > > > > > > > > >> + > > >> +const struct soc_camera_data_format*fmt; > > >

Re: [PATCH 1/5] CSI camera interface driver for MX1

2009-03-26 Thread Mauro Carvalho Chehab
Hi Darius, On Thu, 26 Mar 2009 21:19:24 +0200 Darius Augulis wrote: > Guennadi Liakhovetski wrote: > > Sascha, > > > > would you prefer me to pull this via soc-camera or you'd prefer to handle > > it in your mxc tree? I think it's better to pull it via v4l, so, I'd need > > your acks for platf

Re: [PATCH 1/5] CSI camera interface driver for MX1

2009-03-26 Thread Darius Augulis
Guennadi Liakhovetski wrote: Sascha, would you prefer me to pull this via soc-camera or you'd prefer to handle it in your mxc tree? I think it's better to pull it via v4l, so, I'd need your acks for platform parts, especially for the assembly, ksyms and FIQ code. Hi Darius, Hi Guennadi,

Re: [PATCH 1/5] CSI camera interface driver for MX1

2009-03-26 Thread Guennadi Liakhovetski
Sascha, would you prefer me to pull this via soc-camera or you'd prefer to handle it in your mxc tree? I think it's better to pull it via v4l, so, I'd need your acks for platform parts, especially for the assembly, ksyms and FIQ code. Hi Darius, On Tue, 24 Mar 2009, Darius wrote: Please, sen