RE: [PATCH 1/3 v2] media: Add a cached version of the contiguous video buffers

2010-08-09 Thread Pawel Osciak
>Richard Röjfors wrote: >On 08/04/2010 12:34 PM, Pawel Osciak wrote: >>> Richard Röjfors wrote: >>> On 08/04/2010 11:50 AM, Pawel Osciak wrote: > > How do you propose to allocate the buffers? They need to be contiguous > and using uncached memory gave really bad performance.

Re: [PATCH 1/3 v2] media: Add a cached version of the contiguous video buffers

2010-08-05 Thread Richard Röjfors
On 08/04/2010 12:34 PM, Pawel Osciak wrote: Richard Röjfors wrote: On 08/04/2010 11:50 AM, Pawel Osciak wrote: How do you propose to allocate the buffers? They need to be contiguous and using uncached memory gave really bad performance. 829440 bytes is a quite a lot and one can't reliably de

Re: [PATCH 1/3 v2] media: Add a cached version of the contiguous video buffers

2010-08-04 Thread Richard Röjfors
On 08/04/2010 12:34 PM, Pawel Osciak wrote: Richard Röjfors wrote: On 08/04/2010 11:50 AM, Pawel Osciak wrote: How do you propose to allocate the buffers? They need to be contiguous and using uncached memory gave really bad performance. 829440 bytes is a quite a lot and one can't reliably de

RE: [PATCH 1/3 v2] media: Add a cached version of the contiguous video buffers

2010-08-04 Thread Pawel Osciak
>Richard Röjfors wrote: >On 08/04/2010 11:50 AM, Pawel Osciak wrote: >>> >>> How do you propose to allocate the buffers? They need to be contiguous >>> and using uncached memory gave really bad performance. >> >> 829440 bytes is a quite a lot and one can't reliably depend on kmalloc >> to be able

Re: [PATCH 1/3 v2] media: Add a cached version of the contiguous video buffers

2010-08-04 Thread Richard Röjfors
On 08/04/2010 11:50 AM, Pawel Osciak wrote: How do you propose to allocate the buffers? They need to be contiguous and using uncached memory gave really bad performance. 829440 bytes is a quite a lot and one can't reliably depend on kmalloc to be able to allocate such big chunks of contiguous

RE: [PATCH 1/3 v2] media: Add a cached version of the contiguous video buffers

2010-08-04 Thread Pawel Osciak
> Richard Röjfors wrote: >On 08/04/2010 09:55 AM, Pawel Osciak wrote: >> Hi Richard, >> >>> Richard Röjfors wrote: >>> This patch adds another init functions in the videobuf-dma-contig >>> which is named _cached in the end. It creates a buffer factory >>> which allocates buffers using kmalloc and

Re: [PATCH 1/3 v2] media: Add a cached version of the contiguous video buffers

2010-08-04 Thread Richard Röjfors
On 08/04/2010 09:55 AM, Pawel Osciak wrote: Hi Richard, Richard Röjfors wrote: This patch adds another init functions in the videobuf-dma-contig which is named _cached in the end. It creates a buffer factory which allocates buffers using kmalloc and the buffers are cached. Before I review th

RE: [PATCH 1/3 v2] media: Add a cached version of the contiguous video buffers

2010-08-04 Thread Pawel Osciak
Hi Richard, >Richard Röjfors wrote: >This patch adds another init functions in the videobuf-dma-contig >which is named _cached in the end. It creates a buffer factory >which allocates buffers using kmalloc and the buffers are cached. > Before I review this in more detail, could you elaborate more

[PATCH 1/3 v2] media: Add a cached version of the contiguous video buffers

2010-08-03 Thread Richard Röjfors
This patch adds another init functions in the videobuf-dma-contig which is named _cached in the end. It creates a buffer factory which allocates buffers using kmalloc and the buffers are cached. A sync callback is added to sync the buffers. Most of the code is reused from the uncached version a b