Re: [PATCH 1/3] radio-si470x: fix SYSCONFIG1 register set on si470x_start()

2009-12-01 Thread Joonyoung Shim
On 12/2/2009 9:12 AM, Tobias Lorenz wrote: > Hi, > > ok, understood this problem. > So, why not set this in si470x_fops_open directly after the si470x_start? > It seems more appropriate to enable the RDS interrupt after starting the > radio. > OK, it makes sense. I will move it in si470x_fops_o

Re: [PATCH 1/3] radio-si470x: fix SYSCONFIG1 register set on si470x_start()

2009-12-01 Thread Tobias Lorenz
Hi, ok, understood this problem. So, why not set this in si470x_fops_open directly after the si470x_start? It seems more appropriate to enable the RDS interrupt after starting the radio. Bye the way, you pointed me to a bug. Instead of always setting de-emphasis in si470x_start: radio->registers

Re: [PATCH 1/3] radio-si470x: fix SYSCONFIG1 register set on si470x_start()

2009-12-01 Thread Joonyoung Shim
Hi, Tobias. On 12/2/2009 8:39 AM, Tobias Lorenz wrote: > Hi, > > what is the advantage in not setting SYSCONFIG1 into a known state? > At patch 3/3, i am setting the SYSCONFIG1 register for RDS interrupt in i2c probe function, so i need this patch. Do you have other idea? > Bye, > Toby > > Am

Re: [PATCH 1/3] radio-si470x: fix SYSCONFIG1 register set on si470x_start()

2009-12-01 Thread Tobias Lorenz
Hi, what is the advantage in not setting SYSCONFIG1 into a known state? Bye, Toby Am Mittwoch 18 November 2009 07:21:25 schrieb Joonyoung Shim: > We should use the or operation to set value to the SYSCONFIG1 register > on si470x_start(). > > Signed-off-by: Joonyoung Shim > --- > drivers/media

[PATCH 1/3] radio-si470x: fix SYSCONFIG1 register set on si470x_start()

2009-11-17 Thread Joonyoung Shim
We should use the or operation to set value to the SYSCONFIG1 register on si470x_start(). Signed-off-by: Joonyoung Shim --- drivers/media/radio/si470x/radio-si470x-common.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/media/radio/si470x/radio-si470x-common.c