W dniu 01.10.2019 o 19:35, Helen Koike pisze:
I believe just the kcalloc bellow should fix the issue.
But if you want to do this cleanup anyway, I would suggest sending a separate
patch for it.
@@ -199,7 +197,7 @@ static int vimc_register_devices(struct vimc_device *vimc)
}
On 10/1/19 2:25 PM, Andrzej Pietrasiewicz wrote:
> Hi Dafna, hi Helen,
>
> W dniu 01.10.2019 o 19:19, Helen Koike pisze:
>> Hi Dafna,
>>
>> On 10/1/19 1:50 PM, Dafna Hirschfeld wrote:
>>> since NULL value for vimc entity pointer indicates
>>> that entity creation failed and this is tested, the
Hi Dafna, hi Helen,
W dniu 01.10.2019 o 19:19, Helen Koike pisze:
Hi Dafna,
On 10/1/19 1:50 PM, Dafna Hirschfeld wrote:
since NULL value for vimc entity pointer indicates
that entity creation failed and this is tested, the
pointers should be initialized to NULL.
Nice catch :)
Signed-off-b
Hi Dafna,
On 10/1/19 1:50 PM, Dafna Hirschfeld wrote:
> since NULL value for vimc entity pointer indicates
> that entity creation failed and this is tested, the
> pointers should be initialized to NULL.
Nice catch :)
>
> Signed-off-by: Dafna Hirschfeld
> ---
> drivers/media/platform/vimc/vimc
since NULL value for vimc entity pointer indicates
that entity creation failed and this is tested, the
pointers should be initialized to NULL.
Signed-off-by: Dafna Hirschfeld
---
drivers/media/platform/vimc/vimc-core.c | 8 +++-
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/d