Re: [PATCH 1/3] media: vimc: initialize vim entity pointers to NULL

2019-10-01 Thread Andrzej Pietrasiewicz
W dniu 01.10.2019 o 19:35, Helen Koike pisze: I believe just the kcalloc bellow should fix the issue. But if you want to do this cleanup anyway, I would suggest sending a separate patch for it. @@ -199,7 +197,7 @@ static int vimc_register_devices(struct vimc_device *vimc)   }     

Re: [PATCH 1/3] media: vimc: initialize vim entity pointers to NULL

2019-10-01 Thread Helen Koike
On 10/1/19 2:25 PM, Andrzej Pietrasiewicz wrote: > Hi Dafna, hi Helen, > > W dniu 01.10.2019 o 19:19, Helen Koike pisze: >> Hi Dafna, >> >> On 10/1/19 1:50 PM, Dafna Hirschfeld wrote: >>> since NULL value for vimc entity pointer indicates >>> that entity creation failed and this is tested, the

Re: [PATCH 1/3] media: vimc: initialize vim entity pointers to NULL

2019-10-01 Thread Andrzej Pietrasiewicz
Hi Dafna, hi Helen, W dniu 01.10.2019 o 19:19, Helen Koike pisze: Hi Dafna, On 10/1/19 1:50 PM, Dafna Hirschfeld wrote: since NULL value for vimc entity pointer indicates that entity creation failed and this is tested, the pointers should be initialized to NULL. Nice catch :) Signed-off-b

Re: [PATCH 1/3] media: vimc: initialize vim entity pointers to NULL

2019-10-01 Thread Helen Koike
Hi Dafna, On 10/1/19 1:50 PM, Dafna Hirschfeld wrote: > since NULL value for vimc entity pointer indicates > that entity creation failed and this is tested, the > pointers should be initialized to NULL. Nice catch :) > > Signed-off-by: Dafna Hirschfeld > --- > drivers/media/platform/vimc/vimc

[PATCH 1/3] media: vimc: initialize vim entity pointers to NULL

2019-10-01 Thread Dafna Hirschfeld
since NULL value for vimc entity pointer indicates that entity creation failed and this is tested, the pointers should be initialized to NULL. Signed-off-by: Dafna Hirschfeld --- drivers/media/platform/vimc/vimc-core.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/d