Re: [PATCH 1/3] media: imx7-media-csi: Use functions instead of macros

2019-06-03 Thread Rui Miguel Silva
Oi Fabio, On Sat 01 Jun 2019 at 18:51, Fabio Estevam wrote: > Currently there is a macro for reading and another macro for writing > to the CSI registers. > > Functions can do parameter type checking, which leads to a safer code, > so switch from macro to function implementation. > > Signed-off-by:

[PATCH 1/3] media: imx7-media-csi: Use functions instead of macros

2019-06-01 Thread Fabio Estevam
Currently there is a macro for reading and another macro for writing to the CSI registers. Functions can do parameter type checking, which leads to a safer code, so switch from macro to function implementation. Signed-off-by: Fabio Estevam --- drivers/staging/media/imx/imx7-media-csi.c | 14 +++