Re: [PATCH 1/3] media: i2c: ov02a10: Add ov02a10 camera sensor driver

2019-06-26 Thread Sakari Ailus
Hi Dongchun, On Tue, Jun 11, 2019 at 10:09:49PM +0800, Dongchun Zhu wrote: ... > > > + return -EINVAL; > > > + > > > + fse->code = MEDIA_BUS_FMT_SBGGR10_1X10; > > > > Instead you need check the caller set this. The frame sizes could be > > different for different media bus formats. > > >

Re: [PATCH 1/3] media: i2c: ov02a10: Add ov02a10 camera sensor driver

2019-06-13 Thread Dongchun Zhu
Hi Nicolas, On Sun, 2019-05-26 at 16:53 +0800, Nicolas Boichat wrote: > On Thu, May 23, 2019 at 6:22 PM wrote: > > > > From: Dongchun Zhu > > > > Add a V4L2 sub-device driver for the OmniVision image sensor. > > This is a camera sensor using the I2C bus for control and the > > CSI-2 bus for data

Re: [PATCH 1/3] media: i2c: ov02a10: Add ov02a10 camera sensor driver

2019-06-13 Thread Dongchun Zhu
Hi Bingbu, On Tue, 2019-05-28 at 14:20 +0800, Bingbu Cao wrote: > > On 5/23/19 6:22 PM, dongchun@mediatek.com wrote: > > From: Dongchun Zhu > > > > Add a V4L2 sub-device driver for the OmniVision image sensor. > > This is a camera sensor using the I2C bus for control and the > > CSI-2 bus f

Re: [PATCH 1/3] media: i2c: ov02a10: Add ov02a10 camera sensor driver

2019-06-11 Thread Dongchun Zhu
Hi Sakari, On Fri, 2019-05-31 at 20:03 +0300, Sakari Ailus wrote: > Hi Dongchun, > > On Thu, May 23, 2019 at 06:22:02PM +0800, dongchun@mediatek.com wrote: > > From: Dongchun Zhu > > > > Add a V4L2 sub-device driver for the OmniVision image sensor. > > This is a camera sensor using the I2C

Re: [PATCH 1/3] media: i2c: ov02a10: Add ov02a10 camera sensor driver

2019-05-31 Thread Sakari Ailus
Hi Dongchun, On Thu, May 23, 2019 at 06:22:02PM +0800, dongchun@mediatek.com wrote: > From: Dongchun Zhu > > Add a V4L2 sub-device driver for the OmniVision image sensor. > This is a camera sensor using the I2C bus for control and the > CSI-2 bus for data. > > Signed-off-by: Dongchun Zhu

Re: [PATCH 1/3] media: i2c: ov02a10: Add ov02a10 camera sensor driver

2019-05-27 Thread Bingbu Cao
On 5/23/19 6:22 PM, dongchun@mediatek.com wrote: > From: Dongchun Zhu > > Add a V4L2 sub-device driver for the OmniVision image sensor. > This is a camera sensor using the I2C bus for control and the > CSI-2 bus for data. > > Signed-off-by: Dongchun Zhu > --- > drivers/media/i2c/Makefil

Re: [PATCH 1/3] media: i2c: ov02a10: Add ov02a10 camera sensor driver

2019-05-26 Thread Nicolas Boichat
On Thu, May 23, 2019 at 6:22 PM wrote: > > From: Dongchun Zhu > > Add a V4L2 sub-device driver for the OmniVision image sensor. > This is a camera sensor using the I2C bus for control and the > CSI-2 bus for data. > > Signed-off-by: Dongchun Zhu > --- > drivers/media/i2c/Makefile |1 + > d

[PATCH 1/3] media: i2c: ov02a10: Add ov02a10 camera sensor driver

2019-05-23 Thread dongchun.zhu
From: Dongchun Zhu Add a V4L2 sub-device driver for the OmniVision image sensor. This is a camera sensor using the I2C bus for control and the CSI-2 bus for data. Signed-off-by: Dongchun Zhu --- drivers/media/i2c/Makefile |1 + drivers/media/i2c/ov02a10.c | 1067 ++