Re: [PATCH 1/3] media: dt-bindings: add bindings for Toshiba TC358746

2019-04-29 Thread Marco Felsch
Hi Rob, sorry instead of adding you to To you was on Cc. Do you have any preferences about the below discussion? Regards, Marco On 19-04-16 12:45, Marco Felsch wrote: > Hi Rob, > > gentle ping. > > Regards, > Marco > > On 19-03-05 19:14, Marco Felsch wrote: > > Hi Rob, > > > > I think yo

Re: [PATCH 1/3] media: dt-bindings: add bindings for Toshiba TC358746

2019-04-16 Thread Marco Felsch
Hi Rob, gentle ping. Regards, Marco On 19-03-05 19:14, Marco Felsch wrote: > Hi Rob, > > I think you didn't followed the discussion in detail so I will ask you > personal. In short the tc358746 can act as parallel-in -> csi-out or as > csi->in -> parallel-out device. The phyiscal pins are alw

Re: [PATCH 1/3] media: dt-bindings: add bindings for Toshiba TC358746

2019-03-05 Thread Marco Felsch
Hi Rob, I think you didn't followed the discussion in detail so I will ask you personal. In short the tc358746 can act as parallel-in -> csi-out or as csi->in -> parallel-out device. The phyiscal pins are always the same only the internal timings are different. So we have two ports with two endpoi

Re: [PATCH 1/3] media: dt-bindings: add bindings for Toshiba TC358746

2019-03-05 Thread Jacopo Mondi
Hi Sakari, Marco, On Mon, Mar 04, 2019 at 08:17:48PM +0200, Sakari Ailus wrote: > Hi Marco, > > On Mon, Mar 04, 2019 at 05:55:28PM +0100, Marco Felsch wrote: > > > > (more device specific) > > > > tc358746,default-mode = /* Parallel-in -> CSI-out */ > > > > tc358746,default-mode = /* CSI-in -> P

Re: [PATCH 1/3] media: dt-bindings: add bindings for Toshiba TC358746

2019-03-04 Thread Sakari Ailus
Hi Marco, On Mon, Mar 04, 2019 at 05:55:28PM +0100, Marco Felsch wrote: > > > (more device specific) > > > tc358746,default-mode = /* Parallel-in -> CSI-out */ > > > tc358746,default-mode = /* CSI-in -> Parallel-out */ > > > > > > or > > > > > > (more generic) > > > tc358746,default-dir = > >

Re: [PATCH 1/3] media: dt-bindings: add bindings for Toshiba TC358746

2019-03-04 Thread Marco Felsch
Hi Sakari, On 19-03-04 14:36, Sakari Ailus wrote: > Hi Marco, > > On Fri, Mar 01, 2019 at 02:01:18PM +0100, Marco Felsch wrote: > > Hi Ian, > > > > On 19-03-01 11:07, Ian Arkver wrote: > > > Hi, > > > > > > On 01/03/2019 10:52, Marco Felsch wrote: > > > > Hi Sakari, > > > > > > > > On 19-02-18

Re: [PATCH 1/3] media: dt-bindings: add bindings for Toshiba TC358746

2019-03-04 Thread Marco Felsch
Hi Jacopo, On 19-03-04 10:38, Jacopo Mondi wrote: > Hi Marco, > > On Fri, Mar 01, 2019 at 11:26:48AM +0100, Marco Felsch wrote: > > On 19-02-13 18:57, Jacopo Mondi wrote: > > > Hi Marco, > > > thanks for the patch. > > > > > > I have some comments, which I hope might get the ball rolling... >

Re: [PATCH 1/3] media: dt-bindings: add bindings for Toshiba TC358746

2019-03-04 Thread Sakari Ailus
Hi Marco, On Fri, Mar 01, 2019 at 02:01:18PM +0100, Marco Felsch wrote: > Hi Ian, > > On 19-03-01 11:07, Ian Arkver wrote: > > Hi, > > > > On 01/03/2019 10:52, Marco Felsch wrote: > > > Hi Sakari, > > > > > > On 19-02-18 12:03, Sakari Ailus wrote: > > > > Hi Marco, > > > > > > > > My apologies

Re: [PATCH 1/3] media: dt-bindings: add bindings for Toshiba TC358746

2019-03-04 Thread Sakari Ailus
Hi Macro, On Fri, Mar 01, 2019 at 11:52:35AM +0100, Marco Felsch wrote: > Hi Sakari, > > On 19-02-18 12:03, Sakari Ailus wrote: > > Hi Marco, > > > > My apologies for reviewing this so late. You've received good comments > > already. I have a few more. > > Thanks for your review for the other p

Re: [PATCH 1/3] media: dt-bindings: add bindings for Toshiba TC358746

2019-03-04 Thread Jacopo Mondi
Hi Marco, Ian, On Fri, Mar 01, 2019 at 02:01:18PM +0100, Marco Felsch wrote: > Hi Ian, > > On 19-03-01 11:07, Ian Arkver wrote: > > Hi, > > > > On 01/03/2019 10:52, Marco Felsch wrote: > > > Hi Sakari, > > > > > > On 19-02-18 12:03, Sakari Ailus wrote: > > > > Hi Marco, > > > > > > > > My apologie

Re: [PATCH 1/3] media: dt-bindings: add bindings for Toshiba TC358746

2019-03-04 Thread Jacopo Mondi
Hi Marco, On Fri, Mar 01, 2019 at 11:26:48AM +0100, Marco Felsch wrote: > On 19-02-13 18:57, Jacopo Mondi wrote: > > Hi Marco, > > thanks for the patch. > > > > I have some comments, which I hope might get the ball rolling... > > Hi Jacopo, > > thanks for your review and sorry for the late res

Re: [PATCH 1/3] media: dt-bindings: add bindings for Toshiba TC358746

2019-03-01 Thread Marco Felsch
Hi Ian, On 19-03-01 11:07, Ian Arkver wrote: > Hi, > > On 01/03/2019 10:52, Marco Felsch wrote: > > Hi Sakari, > > > > On 19-02-18 12:03, Sakari Ailus wrote: > > > Hi Marco, > > > > > > My apologies for reviewing this so late. You've received good comments > > > already. I have a few more. > >

Re: [PATCH 1/3] media: dt-bindings: add bindings for Toshiba TC358746

2019-03-01 Thread Ian Arkver
Hi, On 01/03/2019 10:52, Marco Felsch wrote: Hi Sakari, On 19-02-18 12:03, Sakari Ailus wrote: Hi Marco, My apologies for reviewing this so late. You've received good comments already. I have a few more. Thanks for your review for the other patches as well =) Sorry for my delayed response.

Re: [PATCH 1/3] media: dt-bindings: add bindings for Toshiba TC358746

2019-03-01 Thread Marco Felsch
Hi Sakari, On 19-02-18 12:03, Sakari Ailus wrote: > Hi Marco, > > My apologies for reviewing this so late. You've received good comments > already. I have a few more. Thanks for your review for the other patches as well =) Sorry for my delayed response. > On Tue, Dec 18, 2018 at 03:12:38PM +010

Re: [PATCH 1/3] media: dt-bindings: add bindings for Toshiba TC358746

2019-03-01 Thread Marco Felsch
On 19-02-13 18:57, Jacopo Mondi wrote: > Hi Marco, > thanks for the patch. > > I have some comments, which I hope might get the ball rolling... Hi Jacopo, thanks for your review and sorry for the late response. My schedule was a bit filled. > > On Tue, Dec 18, 2018 at 03:12:38PM +0100, Mar

Re: [PATCH 1/3] media: dt-bindings: add bindings for Toshiba TC358746

2019-02-18 Thread Sakari Ailus
Hi Marco, My apologies for reviewing this so late. You've received good comments already. I have a few more. On Tue, Dec 18, 2018 at 03:12:38PM +0100, Marco Felsch wrote: > Add corresponding dt-bindings for the Toshiba tc358746 device. > > Signed-off-by: Marco Felsch > --- > .../bindings/media

Re: [PATCH 1/3] media: dt-bindings: add bindings for Toshiba TC358746

2019-02-13 Thread Jacopo Mondi
Hi Marco, thanks for the patch. I have some comments, which I hope might get the ball rolling... On Tue, Dec 18, 2018 at 03:12:38PM +0100, Marco Felsch wrote: > Add corresponding dt-bindings for the Toshiba tc358746 device. > > Signed-off-by: Marco Felsch > --- > .../bindings/media/i2c/tosh

Re: [PATCH 1/3] media: dt-bindings: add bindings for Toshiba TC358746

2018-12-28 Thread Rob Herring
On Tue, 18 Dec 2018 15:12:38 +0100, Marco Felsch wrote: > Add corresponding dt-bindings for the Toshiba tc358746 device. > > Signed-off-by: Marco Felsch > --- > .../bindings/media/i2c/toshiba,tc358746.txt | 80 +++ > 1 file changed, 80 insertions(+) > create mode 100644 > Doc

[PATCH 1/3] media: dt-bindings: add bindings for Toshiba TC358746

2018-12-18 Thread Marco Felsch
Add corresponding dt-bindings for the Toshiba tc358746 device. Signed-off-by: Marco Felsch --- .../bindings/media/i2c/toshiba,tc358746.txt | 80 +++ 1 file changed, 80 insertions(+) create mode 100644 Documentation/devicetree/bindings/media/i2c/toshiba,tc358746.txt diff --gi