2017-10-20 10:12 GMT+02:00 Russell King - ARM Linux :
> On Sat, Oct 14, 2017 at 12:53:35AM +0200, Pierre-Hugues Husson wrote:
>> @@ -2382,6 +2383,18 @@ __dw_hdmi_probe(struct platform_device *pdev,
>> goto err_isfr;
>> }
>>
>> + hdmi->cec_clk = devm_clk_get(hdmi->dev, "cec")
On Sat, Oct 14, 2017 at 12:53:35AM +0200, Pierre-Hugues Husson wrote:
> @@ -2382,6 +2383,18 @@ __dw_hdmi_probe(struct platform_device *pdev,
> goto err_isfr;
> }
>
> + hdmi->cec_clk = devm_clk_get(hdmi->dev, "cec");
> + if (IS_ERR(hdmi->cec_clk)) {
> + hdmi
On 14/10/17 10:16, Hans Verkuil wrote:
> On 10/14/2017 12:53 AM, Pierre-Hugues Husson wrote:
>> The documentation already mentions "cec" optional clock, but
>> currently the driver doesn't enable it.
>>
>> Signed-off-by: Pierre-Hugues Husson
>
> Acked-by: Hans Verkuil
Tested-by: Hans Verkuil
Hi Pierre,
On Sat, Oct 14, 2017 at 10:21 AM, Pierre-Hugues Husson wrote:
> As far as I understand, dw_hdmi_cec_enable only gates
> the CEC clock inside the Synopsis IP,
> but the SOC still has to provide a specific CEC clock to it.
> To enable such an external CEC clock, the binding documentatio
Hi Fabio,
2017-10-14 2:18 GMT+02:00 Fabio Estevam :
> Hi Pierre-Hugues,
>
> On Fri, Oct 13, 2017 at 7:53 PM, Pierre-Hugues Husson wrote:
>> The documentation already mentions "cec" optional clock, but
>> currently the driver doesn't enable it.
>
> The cec clock is enabled at dw_hdmi_cec_enable().
On 10/14/2017 12:53 AM, Pierre-Hugues Husson wrote:
> The documentation already mentions "cec" optional clock, but
> currently the driver doesn't enable it.
>
> Signed-off-by: Pierre-Hugues Husson
Acked-by: Hans Verkuil
Thanks!
Hans
> ---
> drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
Hi Pierre-Hugues,
On Fri, Oct 13, 2017 at 7:53 PM, Pierre-Hugues Husson wrote:
> The documentation already mentions "cec" optional clock, but
> currently the driver doesn't enable it.
The cec clock is enabled at dw_hdmi_cec_enable().
The documentation already mentions "cec" optional clock, but
currently the driver doesn't enable it.
Signed-off-by: Pierre-Hugues Husson
---
drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 17 +
1 file changed, 17 insertions(+)
diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
