Re: [PATCH 1/2] vb2: drop v4l2_format argument from queue_setup

2015-11-08 Thread Hans Verkuil
On 11/07/2015 09:40 PM, Sakari Ailus wrote: > Hi Hans, > > On Thu, Oct 29, 2015 at 05:24:25AM +0100, Hans Verkuil wrote: >> From: Hans Verkuil >> >> The queue_setup callback has a void pointer that is just for V4L2 >> and is the pointer to the v4l2_format struct that was passed to >> VIDIOC_CREAT

Re: [PATCH 1/2] vb2: drop v4l2_format argument from queue_setup

2015-11-07 Thread Sakari Ailus
Hi Hans, On Thu, Oct 29, 2015 at 05:24:25AM +0100, Hans Verkuil wrote: > From: Hans Verkuil > > The queue_setup callback has a void pointer that is just for V4L2 > and is the pointer to the v4l2_format struct that was passed to > VIDIOC_CREATE_BUFS. The idea was that drivers would use the inform

Re: [PATCH 1/2] vb2: drop v4l2_format argument from queue_setup

2015-11-05 Thread Junghak Sung
Hi Hans, I leave some comments on the body of your patch. On 10/29/2015 01:24 PM, Hans Verkuil wrote: From: Hans Verkuil The queue_setup callback has a void pointer that is just for V4L2 and is the pointer to the v4l2_format struct that was passed to VIDIOC_CREATE_BUFS. The idea was that driv

[PATCH 1/2] vb2: drop v4l2_format argument from queue_setup

2015-10-28 Thread Hans Verkuil
From: Hans Verkuil The queue_setup callback has a void pointer that is just for V4L2 and is the pointer to the v4l2_format struct that was passed to VIDIOC_CREATE_BUFS. The idea was that drivers would use the information from that struct to buffers suitable for the requested format. After the vb