Re: [PATCH 1/2] v4l2 subdevs: replace get/set_crop by get/set_selection

2014-12-07 Thread Sakari Ailus
Hi Laurent, On Mon, Dec 08, 2014 at 02:17:11AM +0200, Laurent Pinchart wrote: > Hi Sakari, > > On Wednesday 03 December 2014 13:06:00 Sakari Ailus wrote: > > On Tue, Dec 02, 2014 at 01:21:40PM +0100, Hans Verkuil wrote: > > > From: Hans Verkuil > > > > > > The crop and selection pad ops are dup

Re: [PATCH 1/2] v4l2 subdevs: replace get/set_crop by get/set_selection

2014-12-07 Thread Laurent Pinchart
Hi Sakari, On Wednesday 03 December 2014 13:06:00 Sakari Ailus wrote: > On Tue, Dec 02, 2014 at 01:21:40PM +0100, Hans Verkuil wrote: > > From: Hans Verkuil > > > > The crop and selection pad ops are duplicates. Replace all uses of > > get/set_crop by get/set_selection. This will make it possibl

Re: [PATCH 1/2] v4l2 subdevs: replace get/set_crop by get/set_selection

2014-12-03 Thread Hans Verkuil
On 12/03/14 12:06, Sakari Ailus wrote: > Hi Hans, > > On Tue, Dec 02, 2014 at 01:21:40PM +0100, Hans Verkuil wrote: >> From: Hans Verkuil >> >> The crop and selection pad ops are duplicates. Replace all uses of >> get/set_crop >> by get/set_selection. This will make it possible to drop get/set_c

Re: [PATCH 1/2] v4l2 subdevs: replace get/set_crop by get/set_selection

2014-12-03 Thread Laurent Pinchart
Hi Hans, On Wednesday 03 December 2014 12:17:57 Hans Verkuil wrote: > On 12/03/14 12:14, Sylwester Nawrocki wrote: > > On 02/12/14 13:21, Hans Verkuil wrote: > >> -static int s5k6aa_set_crop(struct v4l2_subdev *sd, struct v4l2_subdev_fh > >> *fh, > >> - struct v4l2_subdev_crop

Re: [PATCH 1/2] v4l2 subdevs: replace get/set_crop by get/set_selection

2014-12-03 Thread Hans Verkuil
On 12/03/14 12:49, Sylwester Nawrocki wrote: > On 03/12/14 12:17, Hans Verkuil wrote: >> Hi Sylwester, >> >> On 12/03/14 12:14, Sylwester Nawrocki wrote: Hi Hans, On 02/12/14 13:21, Hans Verkuil wrote: >> -static int s5k6aa_set_crop(struct v4l2_subdev *sd, struct >> v4l2_sub

Re: [PATCH 1/2] v4l2 subdevs: replace get/set_crop by get/set_selection

2014-12-03 Thread Sylwester Nawrocki
On 03/12/14 12:17, Hans Verkuil wrote: > Hi Sylwester, > > On 12/03/14 12:14, Sylwester Nawrocki wrote: >> > Hi Hans, >> > >> > On 02/12/14 13:21, Hans Verkuil wrote: >>> >> -static int s5k6aa_set_crop(struct v4l2_subdev *sd, struct >>> >> v4l2_subdev_fh *fh, >>> >> - s

Re: [PATCH 1/2] v4l2 subdevs: replace get/set_crop by get/set_selection

2014-12-03 Thread Hans Verkuil
Hi Sylwester, On 12/03/14 12:14, Sylwester Nawrocki wrote: > Hi Hans, > > On 02/12/14 13:21, Hans Verkuil wrote: >> -static int s5k6aa_set_crop(struct v4l2_subdev *sd, struct v4l2_subdev_fh >> *fh, >> - struct v4l2_subdev_crop *crop) >> +static int s5k6aa_set_selection(stru

Re: [PATCH 1/2] v4l2 subdevs: replace get/set_crop by get/set_selection

2014-12-03 Thread Sakari Ailus
On Wed, Dec 03, 2014 at 12:14:49PM +0100, Sylwester Nawrocki wrote: > Hi Hans, > > On 02/12/14 13:21, Hans Verkuil wrote: > > -static int s5k6aa_set_crop(struct v4l2_subdev *sd, struct v4l2_subdev_fh > > *fh, > > - struct v4l2_subdev_crop *crop) > > +static int s5k6aa_set_sel

Re: [PATCH 1/2] v4l2 subdevs: replace get/set_crop by get/set_selection

2014-12-03 Thread Sylwester Nawrocki
Hi Hans, On 02/12/14 13:21, Hans Verkuil wrote: > -static int s5k6aa_set_crop(struct v4l2_subdev *sd, struct v4l2_subdev_fh *fh, > -struct v4l2_subdev_crop *crop) > +static int s5k6aa_set_selection(struct v4l2_subdev *sd, > + struct v4l2_subdev_f

Re: [PATCH 1/2] v4l2 subdevs: replace get/set_crop by get/set_selection

2014-12-03 Thread Sakari Ailus
Hi Hans, On Tue, Dec 02, 2014 at 01:21:40PM +0100, Hans Verkuil wrote: > From: Hans Verkuil > > The crop and selection pad ops are duplicates. Replace all uses of > get/set_crop > by get/set_selection. This will make it possible to drop get/set_crop > altogether. > > Signed-off-by: Hans Verkui

Re: [PATCH 1/2] v4l2 subdevs: replace get/set_crop by get/set_selection

2014-12-02 Thread Prabhakar Lad
Hi Hans, Thanks for the patch. On Tue, Dec 2, 2014 at 12:21 PM, Hans Verkuil wrote: > From: Hans Verkuil > > The crop and selection pad ops are duplicates. Replace all uses of > get/set_crop > by get/set_selection. This will make it possible to drop get/set_crop > altogether. > > Signed-off-by

Re: [PATCH 1/2] v4l2 subdevs: replace get/set_crop by get/set_selection

2014-12-02 Thread Laurent Pinchart
Hi Hans, Thank you for the patch. On Tuesday 02 December 2014 13:21:40 Hans Verkuil wrote: > From: Hans Verkuil > > The crop and selection pad ops are duplicates. Replace all uses of > get/set_crop by get/set_selection. This will make it possible to drop > get/set_crop altogether. > > Signed-o

[PATCH 1/2] v4l2 subdevs: replace get/set_crop by get/set_selection

2014-12-02 Thread Hans Verkuil
From: Hans Verkuil The crop and selection pad ops are duplicates. Replace all uses of get/set_crop by get/set_selection. This will make it possible to drop get/set_crop altogether. Signed-off-by: Hans Verkuil Cc: Sylwester Nawrocki Cc: Laurent Pinchart Cc: Prabhakar Lad Cc: Philipp Zabel --