Re: [PATCH 1/2] mt9p031: Add mt9p031 sensor driver.

2011-05-18 Thread Laurent Pinchart
Hi Javier, On Wednesday 18 May 2011 11:10:03 javier Martin wrote: > Hi Laurent, > I've already fixed almost every issue you pointed out. > However, I still have got some doubts that I hope you can clarify. > > On 17 May 2011 13:33, Laurent Pinchart wrote: > > On Tuesday 17 May 2011 11:28:47 Javie

Re: [PATCH 1/2] mt9p031: Add mt9p031 sensor driver.

2011-05-18 Thread javier Martin
Hi Ivan, On 17 May 2011 19:14, Ivan Nazarenko wrote: > Javier, > > I have been using the aptina patch (https://github.com/Aptina/BeagleBoard-xM) > on beagleboard while waiting linux-media solve this mt9p031 issue. Now that > you have something working, I would like to try it - but I would like

Re: [PATCH 1/2] mt9p031: Add mt9p031 sensor driver.

2011-05-18 Thread javier Martin
Hi Laurent, I've already fixed almost every issue you pointed out. However, I still have got some doubts that I hope you can clarify. On 17 May 2011 13:33, Laurent Pinchart wrote: > Hi Javier, > > Thanks for the patch. > > On Tuesday 17 May 2011 11:28:47 Javier Martin wrote: >> It has been tested

Re: [PATCH 1/2] mt9p031: Add mt9p031 sensor driver.

2011-05-18 Thread Laurent Pinchart
Hi Chris, On Wednesday 18 May 2011 07:09:44 Chris Rodley wrote: > > Trying out the new patch.. I get this error: > > root@beagle:~# modprobe iommu2 > [ 24.691375] omap-iommu omap-iommu.0: isp registered > root@beagle:~# modprobe omap3_isp > [ 26.923065] Linux video capture interface: v2.00 >

Re: [PATCH 1/2] mt9p031: Add mt9p031 sensor driver.

2011-05-17 Thread Russell King - ARM Linux
On Tue, May 17, 2011 at 01:33:52PM +0200, Laurent Pinchart wrote: > Hi Javier, > > Thanks for the patch. Sorry, but this laziness is getting beyond a joke... And the fact that apparantly no one is picking up on it other than me is also a joke. > > +static int mt9p031_power_on(struct mt9p031 *mt

Re: [PATCH 1/2] mt9p031: Add mt9p031 sensor driver.

2011-05-17 Thread Ivan Nazarenko
Javier, I have been using the aptina patch (https://github.com/Aptina/BeagleBoard-xM) on beagleboard while waiting linux-media solve this mt9p031 issue. Now that you have something working, I would like to try it - but I would like to know what is the clock rate you actually drove the sensor.

Re: [PATCH 1/2] mt9p031: Add mt9p031 sensor driver.

2011-05-17 Thread javier Martin
On 17 May 2011 13:47, Guennadi Liakhovetski wrote: > Hi Laurent > > Thanks for your review! Javier, if you like, you can wait a couple of days > until I find some time to review the driver, or you can submit a version, > addressing Laurent's points, but be prepared to have to do another one;) > >

Re: [PATCH 1/2] mt9p031: Add mt9p031 sensor driver.

2011-05-17 Thread Guennadi Liakhovetski
Hi Laurent Thanks for your review! Javier, if you like, you can wait a couple of days until I find some time to review the driver, or you can submit a version, addressing Laurent's points, but be prepared to have to do another one;) Thanks Guennadi --- Guennadi Liakhovetski, Ph.D. Freelance Ope

Re: [PATCH 1/2] mt9p031: Add mt9p031 sensor driver.

2011-05-17 Thread Laurent Pinchart
Hi Javier, Thanks for the patch. On Tuesday 17 May 2011 11:28:47 Javier Martin wrote: > It has been tested in beagleboard xM, using LI-5M03 module. > > Signed-off-by: Javier Martin [snip] > diff --git a/drivers/media/video/mt9p031.c b/drivers/media/video/mt9p031.c > new file mode 100644 > ind

[PATCH 1/2] mt9p031: Add mt9p031 sensor driver.

2011-05-17 Thread Javier Martin
It has been tested in beagleboard xM, using LI-5M03 module. Signed-off-by: Javier Martin --- drivers/media/video/Kconfig |8 + drivers/media/video/Makefile|1 + drivers/media/video/mt9p031.c | 773 +++ include/media/mt9p031.h | 11